Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: tools/dom/src/native_DOMImplementation.dart

Issue 1424133002: Fix broken console evaluation in devtools when stopped at an async frame. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: ptal Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of html; 5 part of html;
6 6
7 class _Property { 7 class _Property {
8 _Property(this.name) : 8 _Property(this.name) :
9 _hasValue = false, 9 _hasValue = false,
10 writable = false, 10 writable = false,
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 var sb = new StringBuffer("("); 259 var sb = new StringBuffer("(");
260 addArg(arg, value) { 260 addArg(arg, value) {
261 arg = stripMemberName(arg); 261 arg = stripMemberName(arg);
262 if (args.containsKey(arg)) return; 262 if (args.containsKey(arg)) return;
263 // We ignore arguments with the name 'this' rather than throwing an 263 // We ignore arguments with the name 'this' rather than throwing an
264 // exception because Dart_GetLocalVariables includes 'this' and it 264 // exception because Dart_GetLocalVariables includes 'this' and it
265 // is more convenient to filter it out here than from C++ code. 265 // is more convenient to filter it out here than from C++ code.
266 // 'this' needs to be handled by calling Dart_EvaluateExpr with 266 // 'this' needs to be handled by calling Dart_EvaluateExpr with
267 // 'this' as the target rather than by passing it as an argument. 267 // 'this' as the target rather than by passing it as an argument.
268 if (arg == 'this') return; 268 if (arg == 'this') return;
269 // Avoid being broken by bogus ':async_op' local passed in when within
270 // an async method.
271 if (arg.startsWith(':')) return;
269 if (args.isNotEmpty) { 272 if (args.isNotEmpty) {
270 sb.write(", "); 273 sb.write(", ");
271 } 274 }
272 sb.write("final $arg"); 275 sb.write("final $arg");
273 args[arg] = value; 276 args[arg] = value;
274 } 277 }
275 278
276 if (includeCommandLineAPI) { 279 if (includeCommandLineAPI) {
277 addArg("\$consoleVariables", _consoleTempVariables); 280 addArg("\$consoleVariables", _consoleTempVariables);
278 281
(...skipping 830 matching lines...) Expand 10 before | Expand all | Expand 10 after
1109 _scheduleImmediateHelper._schedule(callback); 1112 _scheduleImmediateHelper._schedule(callback);
1110 }; 1113 };
1111 1114
1112 get _pureIsolateScheduleImmediateClosure => ((void callback()) => 1115 get _pureIsolateScheduleImmediateClosure => ((void callback()) =>
1113 throw new UnimplementedError("scheduleMicrotask in background isolates " 1116 throw new UnimplementedError("scheduleMicrotask in background isolates "
1114 "are not supported in the browser")); 1117 "are not supported in the browser"));
1115 1118
1116 // Class for unsupported native browser 'DOM' objects. 1119 // Class for unsupported native browser 'DOM' objects.
1117 class _UnsupportedBrowserObject extends DartHtmlDomObject { 1120 class _UnsupportedBrowserObject extends DartHtmlDomObject {
1118 } 1121 }
OLDNEW
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698