Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 1424113003: Introduce string/regexp related public symbols. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
ulan, Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce string/regexp related public symbols. R=littledan@chromium.org BUG=v8:4305, v8:4343, v8:4344, v8:4345 LOG=N Committed: https://crrev.com/68128834943d4d2d727922a949fc5dfcc3d6a1dd Cr-Commit-Position: refs/heads/master@{#31643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M src/heap/heap.h View 1 chunk +10 lines, -6 lines 0 comments Download
M src/js/symbol.js View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Yang
5 years, 1 month ago (2015-10-28 13:55:16 UTC) #1
Yang
Ulan, could you have a look at the heap change?
5 years, 1 month ago (2015-10-28 13:55:40 UTC) #3
ulan
lgtm
5 years, 1 month ago (2015-10-28 13:58:53 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424113003/1
5 years, 1 month ago (2015-10-28 14:02:00 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-28 14:30:31 UTC) #8
Dan Ehrenberg
lgtm This is fine, but let's not export these as properties on the Symbol global ...
5 years, 1 month ago (2015-10-29 00:57:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424113003/1
5 years, 1 month ago (2015-10-29 05:23:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 05:24:38 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 05:25:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68128834943d4d2d727922a949fc5dfcc3d6a1dd
Cr-Commit-Position: refs/heads/master@{#31643}

Powered by Google App Engine
This is Rietveld 408576698