Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: src/js/symbol.js

Issue 1424113003: Introduce string/regexp related public symbols. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/symbol.js
diff --git a/src/js/symbol.js b/src/js/symbol.js
index 5e79962034177c253210d6a6006e84fde184cf61..4a565cc5fd5408a0578b9b3820ced85d390884b7 100644
--- a/src/js/symbol.js
+++ b/src/js/symbol.js
@@ -19,7 +19,11 @@ var isConcatSpreadableSymbol =
var isRegExpSymbol = utils.ImportNow("is_regexp_symbol");
var iteratorSymbol = utils.ImportNow("iterator_symbol");
var MakeTypeError;
+var matchSymbol = utils.ImportNow("match_symbol");
var ObjectGetOwnPropertyKeys;
+var replaceSymbol = utils.ImportNow("replace_symbol");
+var searchSymbol = utils.ImportNow("search_symbol");
+var splitSymbol = utils.ImportNow("split_symbol");
var toPrimitiveSymbol = utils.ImportNow("to_primitive_symbol");
var toStringTagSymbol = utils.ImportNow("to_string_tag_symbol");
var unscopablesSymbol = utils.ImportNow("unscopables_symbol");
@@ -96,6 +100,11 @@ utils.InstallConstants(GlobalSymbol, [
// "isConcatSpreadable", isConcatSpreadableSymbol,
// "isRegExp", isRegExpSymbol,
"iterator", iteratorSymbol,
+ // TODO(yangguo): expose when implemented.
+ // "match", matchSymbol,
+ // "replace", replaceSymbol,
+ // "search", searchSymbol,
+ // "split, splitSymbol,
"toPrimitive", toPrimitiveSymbol,
// TODO(dslomov, caitp): Currently defined in harmony-tostring.js ---
// Move here when shipping
« no previous file with comments | « src/heap/heap.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698