Eliminate InfoBarTabHelper. Make InfoBarService a concrete class.

Eliminate InfoBarTabHelper.  Make InfoBarService a concrete class.

Most changes here are from inlining and renaming the simple accessors in the
API.

BUG=none
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195922

[Peter Kasting, 2013-04-19 01:01:51]

Closing the circle on InfoBarService/InfoBarTabHelper.

joi: review
ben: OWNERS

[Jói, 2013-04-19 11:05:20]

Hi Peter,

It looks like a lot of the code in infobar_service.cc is copied with little or
no changes from infobar_tab_helper.cc.  Is it possible to preserve history
better?  This would also make the review easier.

If you're in git, I think you need to pass --similarity=XX% to git cl upload to
make it try harder to figure out that one file is derived from another (default
is 50% I think).

Cheers,
Jói

[Jói, 2013-04-19 11:14:37]

I've reviewed, mostly looks good but see below.

Cheers,
Jói

https://codereview.chromium.org/14241006/diff/15001/chrome/browser/infobars/i...
File chrome/browser/infobars/infobar_service.h (left):

https://codereview.chromium.org/14241006/diff/15001/chrome/browser/infobars/i...
chrome/browser/infobars/infobar_service.h:23: static InfoBarService*
FromWebContents(content::WebContents* web_contents);
Where did this go? Looks like it's still called in some places in your change. I
assume CreateForWebContents is also still needed?

[Peter Kasting, 2013-04-19 19:46:30]

New snap up; the .cc file should be easier to review now (if you care), since I
did svn mv instead of svn add this time.  I actually thought of this last night
independent of your review comment but I might have forgotten without the
prompting :)

https://codereview.chromium.org/14241006/diff/15001/chrome/browser/infobars/i...
File chrome/browser/infobars/infobar_service.h (left):

https://codereview.chromium.org/14241006/diff/15001/chrome/browser/infobars/i...
chrome/browser/infobars/infobar_service.h:23: static InfoBarService*
FromWebContents(content::WebContents* web_contents);
On 2013/04/19 11:14:38, Jói wrote:
> Where did this go? Looks like it's still called in some places in your change.
I
> assume CreateForWebContents is also still needed?

Those functions still exist.  By subclassing WebContentsUserData<> (which
defines publicly), InfoBarTabHelper got them as public functions, but since
callers called the InfobarService versions instead of the InfoBarTabHelper ones,
we needed to create wrappers for InfoBarService to call through to the
InfoBarTabHelper versions.  Now that InfoBarService subclasses
WebContentsUserData<> directly, no wrappers are needed -- callers will just
reach the implementations automatically.

[Jói, 2013-04-22 14:24:36]

LGTM, thanks.

[sky, 2013-04-23 20:52:44]

LGTM

[Peter Kasting, 2013-04-23 22:27:43]

Committed patchset #4 manually as r195922 (presubmit successful).