Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4192)

Unified Diff: chrome/browser/ui/website_settings/website_settings_unittest.cc

Issue 14241006: Eliminate InfoBarTabHelper. Make InfoBarService a concrete class. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/website_settings/website_settings_infobar_delegate.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/website_settings/website_settings_unittest.cc
===================================================================
--- chrome/browser/ui/website_settings/website_settings_unittest.cc (revision 195254)
+++ chrome/browser/ui/website_settings/website_settings_unittest.cc (working copy)
@@ -368,9 +368,9 @@
SetDefaultUIExpectations(mock_ui());
EXPECT_CALL(*mock_ui(), SetSelectedTab(
WebsiteSettingsUI::TAB_ID_PERMISSIONS));
- EXPECT_EQ(0u, infobar_service()->GetInfoBarCount());
+ EXPECT_EQ(0u, infobar_service()->infobar_count());
website_settings()->OnUIClosing();
- EXPECT_EQ(0u, infobar_service()->GetInfoBarCount());
+ EXPECT_EQ(0u, infobar_service()->infobar_count());
}
TEST_F(WebsiteSettingsTest, ShowInfoBar) {
@@ -390,16 +390,15 @@
EXPECT_CALL(*mock_ui(), SetSelectedTab(
WebsiteSettingsUI::TAB_ID_PERMISSIONS));
- EXPECT_EQ(0u, infobar_service()->GetInfoBarCount());
+ EXPECT_EQ(0u, infobar_service()->infobar_count());
website_settings()->OnSitePermissionChanged(
CONTENT_SETTINGS_TYPE_GEOLOCATION, CONTENT_SETTING_ALLOW);
website_settings()->OnUIClosing();
- EXPECT_EQ(1u, infobar_service()->GetInfoBarCount());
+ EXPECT_EQ(1u, infobar_service()->infobar_count());
// Removing an |InfoBarDelegate| from the |InfoBarService| does not delete
// it. Hence the |delegate| must be cleaned up after it was removed from the
// |infobar_service|.
- scoped_ptr<InfoBarDelegate> delegate(
- infobar_service()->GetInfoBarDelegateAt(0));
+ scoped_ptr<InfoBarDelegate> delegate(infobar_service()->infobar_at(0));
infobar_service()->RemoveInfoBar(delegate.get());
}
« no previous file with comments | « chrome/browser/ui/website_settings/website_settings_infobar_delegate.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698