Adds a flag to support "Virtual Time" to the blink scheduler

Adds a flag to support "Virtual Time" to the blink scheduler

For use in Headless Chrome, this patch introduces support for virtual
time.  The idea is if the main thread (or a worker thread) runs out of
non-delayed work to do then we are able to fast forward time to the next
scheduled delayed task.

This is enabled via the new --enable-virtualized-time command line flag.

Currently this does not extend to RAF, and virtual time for workers is
not currently synchronized with anything.

BUG=546953
Committed: https://crrev.com/f65eb2da91a4544d49ea6ddab73cac52b0e338b4
Cr-Commit-Position: refs/heads/master@{#357562}

[alex clarke (OOO till 29th), 2015-10-27 18:02:22]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[alex clarke (OOO till 29th), 2015-10-27 18:02:29]

PTAL

[Sami, 2015-10-28 20:00:35]

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
File components/scheduler/base/lazy_now.h (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
components/scheduler/base/lazy_now.h:8: #include "base/time/tick_clock.h"
nit: Forward decl instead?

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
File components/scheduler/base/nestable_single_thread_task_runner.h (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
components/scheduler/base/nestable_single_thread_task_runner.h:16: class
SCHEDULER_EXPORT NestableSingleThreadTaskRunner
I think this interface needs a better name now that it also deals with time.
Subclasses probably too.

TaskQueueManagerDelegate is straightforward but wordy.

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
components/scheduler/base/nestable_single_thread_task_runner.h:28: virtual void
OnNoMoreWork() = 0;
I think it's a little weird that this method is here rather than on the
observer, especially since only one NestableSingleThreadTaskRunner cares about
this notification.

Didn't we recently talk about adding a similar idle observer for another patch?
WDYT of doing that here?

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
File components/scheduler/base/task_queue_manager_unittest.cc (left):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
components/scheduler/base/task_queue_manager_unittest.cc:133:
TEST_F(TaskQueueManagerTest, NowNotCalledWhenThereAreNoDelayedTasks) {
Can we still test for this somehow?

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
File components/scheduler/child/scheduler_helper.h (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
components/scheduler/child/scheduler_helper.h:86: base::TimeTicks Now() const;
This looks redundant now.

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
File components/scheduler/child/virtual_time_task_runner_delegate.cc (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
components/scheduler/child/virtual_time_task_runner_delegate.cc:71: now_ = now;
DCHECK_GT(now, now_);

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
File components/scheduler/child/virtual_time_task_runner_delegate_impl.h
(right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
components/scheduler/child/virtual_time_task_runner_delegate_impl.h:41: void
SetFastForwardTimers(bool fast_forward_timers);
nit: "Timers" aren't really a thing at this level.

Did we decide that we wouldn't need this toggle after all? Maybe we should just
leave it out.

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
components/scheduler/child/virtual_time_task_runner_delegate_impl.h:60: bool
bool fast_forward_timers_;
typo: double bool (didn't realize this even compiled :)

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/re...
File components/scheduler/renderer/renderer_scheduler_impl.cc (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/re...
components/scheduler/renderer/renderer_scheduler_impl.cc:967: switch
(time_source_) {
Do we need to make this distinction here? Why not always call into the helper?

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/sc...
File components/scheduler/scheduler.gypi (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/sc...
components/scheduler/scheduler.gypi:8: 'common/scheduler_switches.cc',
I think you left out these files.

https://codereview.chromium.org/1424053002/diff/20001/content/renderer/render...
File content/renderer/renderer_blink_platform_impl.h (right):

https://codereview.chromium.org/1424053002/diff/20001/content/renderer/render...
content/renderer/renderer_blink_platform_impl.h:174: double currentTime()
override;
Should we leave these two out of this patch until we figure out how to handle
the global virtual time => per page virtual time mapping?

[alex clarke (OOO till 29th), 2015-10-29 18:07:18]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2015-10-29 18:07:31]

PTAL

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
File components/scheduler/base/lazy_now.h (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
components/scheduler/base/lazy_now.h:8: #include "base/time/tick_clock.h"
On 2015/10/28 20:00:34, Sami wrote:
> nit: Forward decl instead?

Done.

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
File components/scheduler/base/nestable_single_thread_task_runner.h (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
components/scheduler/base/nestable_single_thread_task_runner.h:16: class
SCHEDULER_EXPORT NestableSingleThreadTaskRunner
On 2015/10/28 20:00:34, Sami wrote:
> I think this interface needs a better name now that it also deals with time.
> Subclasses probably too.
> 
> TaskQueueManagerDelegate is straightforward but wordy.

Done.

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
components/scheduler/base/nestable_single_thread_task_runner.h:28: virtual void
OnNoMoreWork() = 0;
On 2015/10/28 20:00:34, Sami wrote:
> I think it's a little weird that this method is here rather than on the
> observer, especially since only one NestableSingleThreadTaskRunner cares about
> this notification.
> 
> Didn't we recently talk about adding a similar idle observer for another
patch?
> WDYT of doing that here?

Turns out to be really hard to get the interface right.  As discussed offline
lets revisit this later.

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
File components/scheduler/child/virtual_time_task_runner_delegate_impl.h
(right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
components/scheduler/child/virtual_time_task_runner_delegate_impl.h:41: void
SetFastForwardTimers(bool fast_forward_timers);
On 2015/10/28 20:00:35, Sami wrote:
> nit: "Timers" aren't really a thing at this level.
> 
> Did we decide that we wouldn't need this toggle after all? Maybe we should
just
> leave it out.

Yeah looks like this isn't needed anymore.

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
components/scheduler/child/virtual_time_task_runner_delegate_impl.h:60: bool
bool fast_forward_timers_;
On 2015/10/28 20:00:35, Sami wrote:
> typo: double bool (didn't realize this even compiled :)

Done.

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/re...
File components/scheduler/renderer/renderer_scheduler_impl.cc (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/re...
components/scheduler/renderer/renderer_scheduler_impl.cc:967: switch
(time_source_) {
On 2015/10/28 20:00:35, Sami wrote:
> Do we need to make this distinction here? Why not always call into the helper?

As far as I can tell the distinction is important.  Specially (helper_.Now() -
base::TimeTicks::UnixEpoch()) is an approximation to base::Time::Now().

I think it's OK for currentTime to be less accurate if virtual time is enabled. 
I don't think that's a good idea if it's not.

I think the question of whether it should be done here or elsewhere is a valid
one, but I think there's less plumbing if it's done here.  WDYT?

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/sc...
File components/scheduler/scheduler.gypi (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/sc...
components/scheduler/scheduler.gypi:8: 'common/scheduler_switches.cc',
On 2015/10/28 20:00:35, Sami wrote:
> I think you left out these files.

Done.

https://codereview.chromium.org/1424053002/diff/20001/content/renderer/render...
File content/renderer/renderer_blink_platform_impl.h (right):

https://codereview.chromium.org/1424053002/diff/20001/content/renderer/render...
content/renderer/renderer_blink_platform_impl.h:174: double currentTime()
override;
On 2015/10/28 20:00:35, Sami wrote:
> Should we leave these two out of this patch until we figure out how to handle
> the global virtual time => per page virtual time mapping?

We aren't planning on supporting multiple pages yet, and we have to do this
anyway.  Why not do it now?

Down the line this is wired up in a way that will let us perform the mapping
correctly (either RendererSchedulerImpl, or a class it delegates the logic to,
will be able to do the mapping).

[commit-bot: I haz the power, 2015-10-29 18:08:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424053002/40001

[alex clarke (OOO till 29th), 2015-10-29 18:08:26]

BTW I didn't forget about that test that got removed.  I think I have an idea
but didn't get around to it.

[commit-bot: I haz the power, 2015-10-29 18:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 18:18:33]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[alex clarke (OOO till 29th), 2015-10-29 18:23:14]

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
File components/scheduler/child/scheduler_helper.h (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
components/scheduler/child/scheduler_helper.h:86: base::TimeTicks Now() const;
On 2015/10/28 20:00:35, Sami wrote:
> This looks redundant now.

Done.

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
File components/scheduler/child/virtual_time_task_runner_delegate.cc (right):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ch...
components/scheduler/child/virtual_time_task_runner_delegate.cc:71: now_ = now;
On 2015/10/28 20:00:35, Sami wrote:
> DCHECK_GT(now, now_);

Done.

[alex clarke (OOO till 29th), 2015-10-29 18:23:22]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 18:25:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424053002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424053002/80001

[commit-bot: I haz the power, 2015-10-29 18:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 18:35:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2015-10-30 11:11:21]

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ba...
File components/scheduler/base/task_queue_manager.cc (right):

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ba...
components/scheduler/base/task_queue_manager.cc:323: delegate_->OnNoMoreWork();
Were we going to rename this to OnNoMoreImmediateWork or something?

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
File components/scheduler/child/scheduler_task_runner_delegate.h (right):

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
components/scheduler/child/scheduler_task_runner_delegate.h:14: class
SCHEDULER_EXPORT SchedulerTaskRunnerDelegate
Should this now be called SchedulerTaskQueueManagerDelegate? It's a bit wordy so
other suggestions are welcome too.

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
File components/scheduler/child/virtual_time_task_runner_delegate.h (right):

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
components/scheduler/child/virtual_time_task_runner_delegate.h:18: class
SCHEDULER_EXPORT VirtualTimeTaskRunnerDelegate
Similarly VirtualTimeTaskQueueManagerDelegate?

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
File components/scheduler/child/webthread_impl_for_worker_scheduler.cc (right):

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
components/scheduler/child/webthread_impl_for_worker_scheduler.cc:48: // main
thread?
One issue here is that workers will see virtual time in Date.now() etc. but
their timers will fire according to wall clock time. I don't think we need to
fix that in this patch but something to be aware of.

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/co...
File components/scheduler/common/scheduler_switches.cc (right):

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/co...
components/scheduler/common/scheduler_switches.cc:12: // done. This switch is
intended only for use in headless mode.
There's nothing headless-mode specific here so perhaps we don't need to mention
it?

By the way, how do timers in background tabs work with virtualized time? It'll
be as if the throttling isn't there, right? Just thinking about crbug.com/485425
in the context of this.

Incidentally virtual time will nix the 1 ms setTimeout() clamping too.

[alex clarke (OOO till 29th), 2015-10-30 12:11:54]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 12:12:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424053002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424053002/120001

[alex clarke (OOO till 29th), 2015-10-30 12:12:25]

PTAL

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
File components/scheduler/base/task_queue_manager_unittest.cc (left):

https://codereview.chromium.org/1424053002/diff/20001/components/scheduler/ba...
components/scheduler/base/task_queue_manager_unittest.cc:133:
TEST_F(TaskQueueManagerTest, NowNotCalledWhenThereAreNoDelayedTasks) {
On 2015/10/28 20:00:35, Sami wrote:
> Can we still test for this somehow?

Done.

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ba...
File components/scheduler/base/task_queue_manager.cc (right):

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ba...
components/scheduler/base/task_queue_manager.cc:323: delegate_->OnNoMoreWork();
On 2015/10/30 11:11:20, Sami wrote:
> Were we going to rename this to OnNoMoreImmediateWork or something?

Done.

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
File components/scheduler/child/scheduler_task_runner_delegate.h (right):

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
components/scheduler/child/scheduler_task_runner_delegate.h:14: class
SCHEDULER_EXPORT SchedulerTaskRunnerDelegate
On 2015/10/30 11:11:20, Sami wrote:
> Should this now be called SchedulerTaskQueueManagerDelegate? It's a bit wordy
so
> other suggestions are welcome too.

Done.

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
File components/scheduler/child/virtual_time_task_runner_delegate.h (right):

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
components/scheduler/child/virtual_time_task_runner_delegate.h:18: class
SCHEDULER_EXPORT VirtualTimeTaskRunnerDelegate
On 2015/10/30 11:11:20, Sami wrote:
> Similarly VirtualTimeTaskQueueManagerDelegate?

Done.

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
File components/scheduler/child/webthread_impl_for_worker_scheduler.cc (right):

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/ch...
components/scheduler/child/webthread_impl_for_worker_scheduler.cc:48: // main
thread?
On 2015/10/30 11:11:20, Sami wrote:
> One issue here is that workers will see virtual time in Date.now() etc. but
> their timers will fire according to wall clock time. I don't think we need to
> fix that in this patch but something to be aware of.

Acknowledged.

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/co...
File components/scheduler/common/scheduler_switches.cc (right):

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/co...
components/scheduler/common/scheduler_switches.cc:12: // done. This switch is
intended only for use in headless mode.
On 2015/10/30 11:11:20, Sami wrote:
> There's nothing headless-mode specific here so perhaps we don't need to
mention
> it?
> 
> By the way, how do timers in background tabs work with virtualized time? It'll
> be as if the throttling isn't there, right?

Not entirely no.  Timer alignment will still happen but when DoWork runs out of
things to do virtual time will fast forward to the next timer, whatever that
happens to be.

> Just thinking about crbug.com/485425 in the context of this.
Pretty sure this isn't what they want there.

> Incidentally virtual time will nix the 1 ms setTimeout() clamping too.
Right.

[commit-bot: I haz the power, 2015-10-30 12:22:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 12:22:14]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alex clarke (OOO till 29th), 2015-10-30 12:45:57]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 12:46:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424053002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424053002/140001

[commit-bot: I haz the power, 2015-10-30 12:57:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 12:57:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alex clarke (OOO till 29th), 2015-10-30 13:46:54]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 13:51:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424053002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424053002/160001

[commit-bot: I haz the power, 2015-10-30 14:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 14:06:26]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Sami, 2015-10-30 14:09:51]

lgtm with a couple of nits.

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/co...
File components/scheduler/common/scheduler_switches.cc (right):

https://codereview.chromium.org/1424053002/diff/80001/components/scheduler/co...
components/scheduler/common/scheduler_switches.cc:12: // done. This switch is
intended only for use in headless mode.
On 2015/10/30 12:12:25, alexclarke1 wrote:
> On 2015/10/30 11:11:20, Sami wrote:
> > There's nothing headless-mode specific here so perhaps we don't need to
> mention
> > it?
> > 
> > By the way, how do timers in background tabs work with virtualized time?
It'll
> > be as if the throttling isn't there, right?
> 
> Not entirely no.  Timer alignment will still happen but when DoWork runs out
of
> things to do virtual time will fast forward to the next timer, whatever that
> happens to be.

Right, so essentially with virtual time there's no difference between a
foreground and a background tab (except how things interleave).
 
> > Just thinking about crbug.com/485425 in the context of this.
> Pretty sure this isn't what they want there.

Why not? It will make timer based tests execute quickly regardless of tab
visibility. It could break timeout-based logic which may or may not be an issue.

https://codereview.chromium.org/1424053002/diff/160001/components/scheduler/c...
File components/scheduler/child/scheduler_helper.h (right):

https://codereview.chromium.org/1424053002/diff/160001/components/scheduler/c...
components/scheduler/child/scheduler_helper.h:26:
SchedulerHelper(scoped_refptr<SchedulerTqmDelegate> main_task_runner,
Should we do a global rename of |main_task_runner| to
|task_queue_manager_delegate|?

https://codereview.chromium.org/1424053002/diff/160001/components/scheduler/c...
File components/scheduler/child/virtual_time_tqm_delegate.h (right):

https://codereview.chromium.org/1424053002/diff/160001/components/scheduler/c...
components/scheduler/child/virtual_time_tqm_delegate.h:5: #ifndef
COMPONENTS_SCHEDULER_CHILD_VIRTUAL_TIME_TASK_RUNNER_DELEGATE_H_
TQM_DELEGATE

[alex clarke (OOO till 29th), 2015-10-30 14:31:49]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 14:36:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424053002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424053002/180001

[commit-bot: I haz the power, 2015-10-30 15:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 15:12:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alex clarke (OOO till 29th), 2015-10-30 15:54:23]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 15:55:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424053002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424053002/200001

[alex clarke (OOO till 29th), 2015-10-30 16:01:59]

alexclarke@chromium.org changed reviewers:
+ jochen@chromium.org, sandersd@chromium.org

[alex clarke (OOO till 29th), 2015-10-30 16:02:00]

jochen@ please review content/browser change
sandersd@ please review media/blink change

Thanks!

https://codereview.chromium.org/1424053002/diff/160001/components/scheduler/c...
File components/scheduler/child/scheduler_helper.h (right):

https://codereview.chromium.org/1424053002/diff/160001/components/scheduler/c...
components/scheduler/child/scheduler_helper.h:26:
SchedulerHelper(scoped_refptr<SchedulerTqmDelegate> main_task_runner,
On 2015/10/30 14:09:50, Sami wrote:
> Should we do a global rename of |main_task_runner| to
> |task_queue_manager_delegate|?

Done.

https://codereview.chromium.org/1424053002/diff/160001/components/scheduler/c...
File components/scheduler/child/virtual_time_tqm_delegate.h (right):

https://codereview.chromium.org/1424053002/diff/160001/components/scheduler/c...
components/scheduler/child/virtual_time_tqm_delegate.h:5: #ifndef
COMPONENTS_SCHEDULER_CHILD_VIRTUAL_TIME_TASK_RUNNER_DELEGATE_H_
On 2015/10/30 14:09:50, Sami wrote:
> TQM_DELEGATE

Done.

[commit-bot: I haz the power, 2015-10-30 17:00:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 17:00:46]

Dry run: This issue passed the CQ dry run.

[sandersd (OOO until July 31), 2015-11-02 20:07:17]

LGTM for media/

[jochen (gone - plz use gerrit), 2015-11-03 07:21:43]

lgtm

[alex clarke (OOO till 29th), 2015-11-03 11:48:07]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2015-11-03 11:48:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org, jochen@chromium.org, sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/1424053002/#ps220001
(title: "Rebased")

[commit-bot: I haz the power, 2015-11-03 11:48:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424053002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424053002/220001

[commit-bot: I haz the power, 2015-11-03 14:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 14:07:25]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alex clarke (OOO till 29th), 2015-11-03 15:18:30]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-11-03 15:19:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424053002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424053002/220001

[commit-bot: I haz the power, 2015-11-03 18:24:25]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-11-03 18:26:00]

Patchset 12 (id:??) landed as
https://crrev.com/f65eb2da91a4544d49ea6ddab73cac52b0e338b4
Cr-Commit-Position: refs/heads/master@{#357562}