Adds a flag to support "Virtual Time" to the blink scheduler

components/scheduler/base/task_queue_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/scheduler/base/task_queue_manager.h"
 
 #include "base/location.h"
 #include "base/run_loop.h"
 #include "base/single_thread_task_runner.h"
 #include "base/test/simple_test_tick_clock.h"
 #include "base/threading/thread.h"
 #include "cc/test/ordered_simple_task_runner.h"
 #include "components/scheduler/base/nestable_task_runner_for_test.h"
 #include "components/scheduler/base/task_queue_impl.h"
 #include "components/scheduler/base/task_queue_selector.h"
 #include "components/scheduler/base/task_queue_sets.h"
 #include "components/scheduler/base/test_always_fail_time_source.h"
 #include "components/scheduler/base/test_time_source.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
 using testing::ElementsAre;
 using testing::_;
 
 namespace scheduler {
 
 class MessageLoopTaskRunner : public NestableTaskRunnerForTest {
  public:
-  static scoped_refptr<MessageLoopTaskRunner> Create() {
-    return make_scoped_refptr(new MessageLoopTaskRunner());
+  static scoped_refptr<MessageLoopTaskRunner> Create(
+      scoped_ptr<base::TickClock> tick_clock) {
+    return make_scoped_refptr(new MessageLoopTaskRunner(tick_clock.Pass()));
   }
 
   // NestableTaskRunner implementation.
   bool IsNested() const override {
     return base::MessageLoop::current()->IsNested();
   }
 
  private:
-  MessageLoopTaskRunner()
-      : NestableTaskRunnerForTest(base::MessageLoop::current()->task_runner()) {
-  }
+  explicit MessageLoopTaskRunner(scoped_ptr<base::TickClock> tick_clock)
+      : NestableTaskRunnerForTest(base::MessageLoop::current()->task_runner(),
+                                  tick_clock.Pass()) {}
   ~MessageLoopTaskRunner() override {}
 };
 
 class TaskQueueManagerTest : public testing::Test {
  public:
   void DeleteTaskQueueManager() { manager_.reset(); }
 
  protected:
-  void Initialize(size_t num_queues) {
-    now_src_.reset(new base::SimpleTestTickClock());
-    now_src_->Advance(base::TimeDelta::FromMicroseconds(1000));
+  void InitializeWithClock(size_t num_queues,
+                           scoped_ptr<base::TickClock> test_time_source) {
     test_task_runner_ = make_scoped_refptr(
         new cc::OrderedSimpleTaskRunner(now_src_.get(), false));
-    main_task_runner_ =
-        NestableTaskRunnerForTest::Create(test_task_runner_.get());
+    main_task_runner_ = NestableTaskRunnerForTest::Create(
+        test_task_runner_.get(),
+        make_scoped_ptr(new TestTimeSource(now_src_.get())));
     manager_ = make_scoped_ptr(new TaskQueueManager(
         main_task_runner_, "test.scheduler", "test.scheduler",
         "test.scheduler.debug"));
-    manager_->SetTimeSourceForTesting(
-        make_scoped_ptr(new TestTimeSource(now_src_.get())));
 
     for (size_t i = 0; i < num_queues; i++)
       runners_.push_back(manager_->NewTaskQueue(TaskQueue::Spec("test_queue")));
   }
 
+  void Initialize(size_t num_queues) {
+    now_src_.reset(new base::SimpleTestTickClock());
+    now_src_->Advance(base::TimeDelta::FromMicroseconds(1000));
+    InitializeWithClock(num_queues,
+                        make_scoped_ptr(new TestTimeSource(now_src_.get())));
+  }
+
   void InitializeWithRealMessageLoop(size_t num_queues) {
     message_loop_.reset(new base::MessageLoop());
-    manager_ = make_scoped_ptr(
-        new TaskQueueManager(MessageLoopTaskRunner::Create(), "test.scheduler",
-                             "test.scheduler", "test.scheduler.debug"));
+    manager_ = make_scoped_ptr(new TaskQueueManager(
+        MessageLoopTaskRunner::Create(
+            make_scoped_ptr(new TestTimeSource(now_src_.get()))),
+        "test.scheduler", "test.scheduler", "test.scheduler.debug"));
 
     for (size_t i = 0; i < num_queues; i++)
       runners_.push_back(manager_->NewTaskQueue(TaskQueue::Spec("test_queue")));
   }
 
   scoped_ptr<base::MessageLoop> message_loop_;
   scoped_ptr<base::SimpleTestTickClock> now_src_;
   scoped_refptr<NestableTaskRunnerForTest> main_task_runner_;
   scoped_refptr<cc::OrderedSimpleTaskRunner> test_task_runner_;
   scoped_ptr<TaskQueueManager> manager_;
@@ skipping 40 matching lines @@
   runners_[0]->PostTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order));
   runners_[1]->PostTask(FROM_HERE, base::Bind(&TestTask, 3, &run_order));
   runners_[1]->PostTask(FROM_HERE, base::Bind(&TestTask, 4, &run_order));
   runners_[2]->PostTask(FROM_HERE, base::Bind(&TestTask, 5, &run_order));
   runners_[2]->PostTask(FROM_HERE, base::Bind(&TestTask, 6, &run_order));
 
   test_task_runner_->RunUntilIdle();
   EXPECT_THAT(run_order, ElementsAre(1, 2, 3, 4, 5, 6));
 }
 
-void NopTask() {}
-
-TEST_F(TaskQueueManagerTest, NowNotCalledWhenThereAreNoDelayedTasks) {

[Sami, 2015/10/28 20:00:35]

Can we still test for this somehow?

[alex clarke (OOO till 29th), 2015/10/30 12:12:24]

Done.

-  Initialize(3u);
-
-  manager_->SetTimeSourceForTesting(
-      make_scoped_ptr(new TestAlwaysFailTimeSource()));
-
-  runners_[0]->PostTask(FROM_HERE, base::Bind(&NopTask));
-  runners_[0]->PostTask(FROM_HERE, base::Bind(&NopTask));
-  runners_[1]->PostTask(FROM_HERE, base::Bind(&NopTask));
-  runners_[1]->PostTask(FROM_HERE, base::Bind(&NopTask));
-  runners_[2]->PostTask(FROM_HERE, base::Bind(&NopTask));
-  runners_[2]->PostTask(FROM_HERE, base::Bind(&NopTask));
-
-  test_task_runner_->RunUntilIdle();
-}
-
 TEST_F(TaskQueueManagerTest, NonNestableTaskPosting) {
   InitializeWithRealMessageLoop(1u);
 
   std::vector<int> run_order;
   runners_[0]->PostNonNestableTask(FROM_HERE,
                                    base::Bind(&TestTask, 1, &run_order));
 
   message_loop_->RunUntilIdle();
   EXPECT_THAT(run_order, ElementsAre(1));
 }
@@ skipping 68 matching lines @@
   // After the delay has completed, the task runs normally.
   test_task_runner_->RunForPeriod(base::TimeDelta::FromMilliseconds(1));
   EXPECT_THAT(run_order, ElementsAre(1));
 }
 
 bool MessageLoopTaskCounter(size_t* count) {
   *count = *count + 1;
   return true;
 }
 
+void NopTask() {}
+
 TEST_F(TaskQueueManagerTest, DelayedTaskExecutedInOneMessageLoopTask) {
   Initialize(1u);
 
   base::TimeDelta delay(base::TimeDelta::FromMilliseconds(10));
   runners_[0]->PostDelayedTask(FROM_HERE, base::Bind(&NopTask), delay);
 
   size_t task_count = 0;
   test_task_runner_->RunTasksWhile(
       base::Bind(&MessageLoopTaskCounter, &task_count));
   EXPECT_EQ(1u, task_count);
@@ skipping 632 matching lines @@
 }
 
 TEST_F(TaskQueueManagerTest, ThreadCheckAfterTermination) {
   Initialize(1u);
   EXPECT_TRUE(runners_[0]->RunsTasksOnCurrentThread());
   manager_.reset();
   EXPECT_TRUE(runners_[0]->RunsTasksOnCurrentThread());
 }
 
 TEST_F(TaskQueueManagerTest, NextPendingDelayedTaskRunTime) {
-  scoped_ptr<base::SimpleTestTickClock> clock(new base::SimpleTestTickClock());
-  clock->Advance(base::TimeDelta::FromMicroseconds(10000));
   Initialize(2u);
-  manager_->SetTimeSourceForTesting(
-      make_scoped_ptr(new TestTimeSource(clock.get())));
+  now_src_->Advance(base::TimeDelta::FromMicroseconds(10000));
 
   // With no delayed tasks.
   EXPECT_TRUE(manager_->NextPendingDelayedTaskRunTime().is_null());
 
   // With a non-delayed task.
   runners_[0]->PostTask(FROM_HERE, base::Bind(&NopTask));
   EXPECT_TRUE(manager_->NextPendingDelayedTaskRunTime().is_null());
 
   // With a delayed task.
   base::TimeDelta expected_delay = base::TimeDelta::FromMilliseconds(50);
   runners_[0]->PostDelayedTask(FROM_HERE, base::Bind(&NopTask), expected_delay);
-  EXPECT_EQ(clock->NowTicks() + expected_delay,
+  EXPECT_EQ(now_src_->NowTicks() + expected_delay,
             manager_->NextPendingDelayedTaskRunTime());
 
   // With another delayed task in the same queue with a longer delay.
   runners_[0]->PostDelayedTask(FROM_HERE, base::Bind(&NopTask),
                                base::TimeDelta::FromMilliseconds(100));
-  EXPECT_EQ(clock->NowTicks() + expected_delay,
+  EXPECT_EQ(now_src_->NowTicks() + expected_delay,
             manager_->NextPendingDelayedTaskRunTime());
 
   // With another delayed task in the same queue with a shorter delay.
   expected_delay = base::TimeDelta::FromMilliseconds(20);
   runners_[0]->PostDelayedTask(FROM_HERE, base::Bind(&NopTask), expected_delay);
-  EXPECT_EQ(clock->NowTicks() + expected_delay,
+  EXPECT_EQ(now_src_->NowTicks() + expected_delay,
             manager_->NextPendingDelayedTaskRunTime());
 
   // With another delayed task in a different queue with a shorter delay.
   expected_delay = base::TimeDelta::FromMilliseconds(10);
   runners_[1]->PostDelayedTask(FROM_HERE, base::Bind(&NopTask), expected_delay);
-  EXPECT_EQ(clock->NowTicks() + expected_delay,
+  EXPECT_EQ(now_src_->NowTicks() + expected_delay,
             manager_->NextPendingDelayedTaskRunTime());
 
   // Test it updates as time progresses
-  clock->Advance(expected_delay);
-  EXPECT_EQ(clock->NowTicks(), manager_->NextPendingDelayedTaskRunTime());
+  now_src_->Advance(expected_delay);
+  EXPECT_EQ(now_src_->NowTicks(), manager_->NextPendingDelayedTaskRunTime());
 }
 
 TEST_F(TaskQueueManagerTest, NextPendingDelayedTaskRunTime_MultipleQueues) {
   Initialize(3u);
 
   base::TimeDelta delay1 = base::TimeDelta::FromMilliseconds(50);
   base::TimeDelta delay2 = base::TimeDelta::FromMilliseconds(5);
   base::TimeDelta delay3 = base::TimeDelta::FromMilliseconds(10);
   runners_[0]->PostDelayedTask(FROM_HERE, base::Bind(&NopTask), delay1);
   runners_[1]->PostDelayedTask(FROM_HERE, base::Bind(&NopTask), delay2);
@@ skipping 422 matching lines @@
   // release its reference, and checks that it has.
   runners_[0]->PostTask(FROM_HERE,
                         base::Bind(&HasOneRefTask, base::Unretained(&log),
                                    base::Unretained(task_queue.get())));
   message_loop_->RunUntilIdle();
 
   EXPECT_THAT(log, ElementsAre(false, false, true));
 }
 
 }  // namespace scheduler