Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1423993006: RegExp.prototype is an ordinary object. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

RegExp.prototype is an ordinary object. R=littledan@chromium.org BUG=v8:4003 LOG=N Committed: https://crrev.com/538197dadadd8d37a4c996b9dd3f13e7637c780e Cr-Commit-Position: refs/heads/master@{#31730}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -84 lines) Patch
M src/bootstrapper.cc View 1 2 chunks +0 lines, -22 lines 0 comments Download
M src/js/regexp.js View 2 chunks +2 lines, -0 lines 0 comments Download
A test/mjsunit/es6/regexp-prototype.js View 1 chunk +17 lines, -0 lines 0 comments Download
M test/mjsunit/messages.js View 1 chunk +3 lines, -3 lines 0 comments Download
D test/mjsunit/regress/regress-1217.js View 1 chunk +0 lines, -50 lines 0 comments Download
M test/mjsunit/regress/regress-3229.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/test262/test262.status View 1 2 chunks +9 lines, -4 lines 0 comments Download
M test/webkit/fast/js/kde/RegExp-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/fast/regex/toString-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1419823010 Patch 1
Issue 1419823010 Patch 2
Issue 1419823010 Patch 50001

Messages

Total messages: 18 (6 generated)
Yang
5 years, 1 month ago (2015-10-29 08:20:30 UTC) #1
Yang
On 2015/10/29 08:20:30, Yang wrote: ping
5 years, 1 month ago (2015-10-30 05:54:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423993006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423993006/1
5 years, 1 month ago (2015-10-30 05:54:41 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7216)
5 years, 1 month ago (2015-10-30 05:59:11 UTC) #6
Yang
I haven't added flag properties to RegExp.prototype yet, so some tests that assumes RegExp.prototype to ...
5 years, 1 month ago (2015-10-30 06:38:35 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423993006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423993006/20001
5 years, 1 month ago (2015-10-30 13:23:15 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-30 14:04:02 UTC) #12
Yang
On 2015/10/30 14:04:02, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 1 month ago (2015-11-02 10:27:38 UTC) #13
Dan Ehrenberg
lgtm
5 years, 1 month ago (2015-11-02 18:34:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423993006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423993006/20001
5 years, 1 month ago (2015-11-03 05:53:51 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-03 06:18:22 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 06:18:59 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/538197dadadd8d37a4c996b9dd3f13e7637c780e
Cr-Commit-Position: refs/heads/master@{#31730}

Powered by Google App Engine
This is Rietveld 408576698