Chromium Code Reviews Chromium Code Reviews
Issue
142393002:
android: Use use_goma=1 gomadir gyp defines instead of magic GOMA_DIR env var. (Closed)
Descriptionandroid: Use use_goma=1 gomadir gyp defines instead of magic GOMA_DIR env var.
For a short transition period, let envsetup.sh set the right GYP_DEFINES when
GOMA_DIR is set, so that people aren't broken immediately after this lands.
Also stop setting GOMA_COMPILER_PROXY_THREADS – if the value this sets
is truly better, that should be the default in goma, it shouldn't be set in
envsetup.sh (doing it in goma has the advantage that it works on all
platforms, also abstraction barriers, etc.)
BUG=332697
R=brettw@chromium.org, ilevy@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245801
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : . #Patch Set 4 : . #
Total comments: 2
Patch Set 5 : . #Patch Set 6 : test #Patch Set 7 : test2 #Patch Set 8 : test3 #Patch Set 9 : test4 #Patch Set 10 : rebase #Patch Set 11 : notest #Patch Set 12 : nowat #
Messages
Total messages: 8 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
