Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3000)

Unified Diff: build/android/envsetup.sh

Issue 142393002: android: Use use_goma=1 gomadir gyp defines instead of magic GOMA_DIR env var. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nowat Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/buildbot/bb_run_bot.py ('k') | build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/envsetup.sh
diff --git a/build/android/envsetup.sh b/build/android/envsetup.sh
index f7e5a699afe7e87af7db290c6847d42de745b62e..b88923b9523ad048f12a7185ed056fa395567475 100755
--- a/build/android/envsetup.sh
+++ b/build/android/envsetup.sh
@@ -119,15 +119,10 @@ fi
# Source a bunch of helper functions
. ${CHROME_SRC}/build/android/adb_device_functions.sh
+# TODO(thakis), Jan 18 2014: Remove this after two weeks or so, after telling
+# everyone to set use_goma in GYP_DEFINES instead of a GOMA_DIR env var.
if [[ -d $GOMA_DIR ]]; then
- num_cores="$(grep --count ^processor /proc/cpuinfo)"
-# Goma is IO-ish you want more threads than you have cores.
- let "goma_threads=num_cores*2"
- if [ -z "${GOMA_COMPILER_PROXY_THREADS}" -a "${goma_threads}" -gt 16 ]; then
-# The default is 16 threads, if the machine has many cores we crank it up a bit
- GOMA_COMPILER_PROXY_THREADS="${goma_threads}"
- export GOMA_COMPILER_PROXY_THREADS
- fi
+ DEFINES+=" use_goma=1 gomadir=$GOMA_DIR"
fi
# Declare Android are cross compile.
« no previous file with comments | « build/android/buildbot/bb_run_bot.py ('k') | build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698