Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1423833003: Canonicalize handles for optimized compilation. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Canonicalize handles for optimized compilation. R=bmeurer@chromium.org Committed: https://crrev.com/15f36b2b1e166a511966a9991fddea94f890a755 Cr-Commit-Position: refs/heads/master@{#31566} Committed: https://crrev.com/67dc6ce5fde32c1895974903ea566dc0dadd39f7 Cr-Commit-Position: refs/heads/master@{#31576}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -57 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/allocation-site-scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M src/handles.h View 1 6 chunks +47 lines, -5 lines 0 comments Download
M src/handles.cc View 3 chunks +45 lines, -1 line 0 comments Download
M src/handles-inl.h View 5 chunks +34 lines, -20 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/identity-map.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/json-stringifier.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/string-builder.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/string-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-identity-map.cc View 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Yang
5 years, 1 month ago (2015-10-26 12:31:30 UTC) #1
Benedikt Meurer
Awesome. Thanks for doing this. LGTM from my side, not sure if someone else should ...
5 years, 1 month ago (2015-10-26 12:37:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423833003/1
5 years, 1 month ago (2015-10-26 12:57:18 UTC) #4
Yang
Jochen, please take a look at include/v8.h. The change reflects the change in handles-inl.h regarding ...
5 years, 1 month ago (2015-10-26 13:00:55 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-10-26 13:01:33 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-26 13:21:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423833003/1
5 years, 1 month ago (2015-10-26 13:48:15 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 13:49:55 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/15f36b2b1e166a511966a9991fddea94f890a755 Cr-Commit-Position: refs/heads/master@{#31566}
5 years, 1 month ago (2015-10-26 13:50:26 UTC) #13
Yang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1417013007/ by yangguo@chromium.org. ...
5 years, 1 month ago (2015-10-26 14:44:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423833003/20001
5 years, 1 month ago (2015-10-26 14:52:38 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-26 15:33:06 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 15:33:33 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67dc6ce5fde32c1895974903ea566dc0dadd39f7
Cr-Commit-Position: refs/heads/master@{#31576}

Powered by Google App Engine
This is Rietveld 408576698