src/ia32/macro-assembler-ia32.cc - Issue 1423833003: Canonicalize handles for optimized compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 1423833003: Canonicalize handles for optimized compilation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index 7faa2b2c4f35d1668ff68a8a0fca8d107e5b3a84..0b4e600dcc60ecd4b7c4b35a42564f638cbafc6f 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -24,9 +24,8 @@ MacroAssembler::MacroAssembler(Isolate* arg_isolate, void* buffer, int size)

generating_stub_(false),

has_frame_(false) {

if (isolate() != NULL) {

- // TODO(titzer): should we just use a null handle here instead?

- code_object_ = Handle<Object>(isolate()->heap()->undefined_value(),

- isolate());

+ code_object_ =

+ Handle<Object>::New(isolate()->heap()->undefined_value(), isolate());

}

« no previous file with comments | « src/handles-inl.h ('k') | src/identity-map.cc » ('j') | no next file with comments »