chrome/browser/sync_file_system/sync_file_system_service.cc - Issue 14238037: Made it possible to tell whether an extension is being installed or updated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/sync_file_system_service.cc

Issue 14238037: Made it possible to tell whether an extension is being installed or updated. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Test that already_installed is true on update, false on install. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.cc ('K') | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/common/chrome_notification_types.h » ('j') | chrome/common/extensions/extension.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/sync_file_system_service.cc

diff --git a/chrome/browser/sync_file_system/sync_file_system_service.cc b/chrome/browser/sync_file_system/sync_file_system_service.cc

index ba14e1522c4e622654c781e7edffaeeea3f8d6e1..4ba150fc87ab421ac7a6ba927693afe968de7590 100644

--- a/chrome/browser/sync_file_system/sync_file_system_service.cc

+++ b/chrome/browser/sync_file_system/sync_file_system_service.cc

@@ -423,6 +423,7 @@ void SyncFileSystemService::Observe(

// (User action) (Notification type)

// Install: INSTALLED.

+ // Update: INSTALLED.

// Uninstall: UNLOADED(UNINSTALL).

// Launch, Close: No notification.

// Enable: EABLED.

@@ -447,7 +448,9 @@ void SyncFileSystemService::Observe(

void SyncFileSystemService::HandleExtensionInstalled(

const content::NotificationDetails& details) {

- content::Details<const extensions::Extension> extension(details);

+ const extensions::Extension* extension =

+ content::Details<const extensions::InstalledExtensionInfo>(details)->

+ extension;

GURL app_origin =

extensions::Extension::GetBaseURLFromExtensionId(extension->id());

DVLOG(1) << "Handle extension notification for INSTALLED: " << app_origin;