chrome/browser/extensions/extension_service.cc - Issue 14238037: Made it possible to tell whether an extension is being installed or updated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 14238037: Made it possible to tell whether an extension is being installed or updated. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Test that already_installed is true on update, false on install. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_blacklist_browsertest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | chrome/common/extensions/extension.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index d70cadb99a01f0fe798c1ca1d2a0ddb6dcfbfb53..245e5b5a44950fd70985fd5a88499ead16e905aa 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -2423,10 +2423,12 @@ void ExtensionService::FinishDelayedInstallation(

}

void ExtensionService::FinishInstallation(const Extension* extension) {

+ bool already_installed = GetInstalledExtension(extension->id()) != NULL;

benwells 2013/05/02 01:40:08 nit: change this to is_update, i think that is cle

Matt Giuca 2013/05/02 05:40:33 Done.

+ extensions::InstalledExtensionInfo details(extension, already_installed);

content::NotificationService::current()->Notify(

chrome::NOTIFICATION_EXTENSION_INSTALLED,

content::Source<Profile>(profile_),

- content::Details<const Extension>(extension));

+ content::Details<const extensions::InstalledExtensionInfo>(&details));

bool unacknowledged_external = IsUnacknowledgedExternalExtension(extension);