chrome/browser/extensions/updater/extension_updater.cc - Issue 14238037: Made it possible to tell whether an extension is being installed or updated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_updater.cc

Issue 14238037: Made it possible to tell whether an extension is being installed or updated. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Test that already_installed is true on update, false on install. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.cc ('K') | « chrome/browser/extensions/state_store.cc ('k') | chrome/browser/extensions/webstore_installer.cc » ('j') | chrome/common/extensions/extension.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/updater/extension_updater.cc

diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/browser/extensions/updater/extension_updater.cc

index 130da8f8da82f885c662f6c25bb0c0905b1297fd..b0a31c573da43d89a237421faa4a9adf4cb9cce7 100644

--- a/chrome/browser/extensions/updater/extension_updater.cc

+++ b/chrome/browser/extensions/updater/extension_updater.cc

@@ -665,7 +665,7 @@ void ExtensionUpdater::Observe(int type,

}

case chrome::NOTIFICATION_EXTENSION_INSTALLED: {

const Extension* extension =

- content::Details<const Extension>(details).ptr();

+ content::Details<const InstalledExtensionInfo>(details)->extension;

if (extension)

throttle_info_.erase(extension->id());

break;