chrome/browser/chromeos/screensaver/screensaver_controller.cc - Issue 14238037: Made it possible to tell whether an extension is being installed or updated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/screensaver/screensaver_controller.cc

Issue 14238037: Made it possible to tell whether an extension is being installed or updated. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Test that already_installed is true on update, false on install. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/enterprise_extension_observer.cc ('k') | chrome/browser/extensions/api/commands/command_service.cc » ('j') | chrome/browser/extensions/extension_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/screensaver/screensaver_controller.cc

diff --git a/chrome/browser/chromeos/screensaver/screensaver_controller.cc b/chrome/browser/chromeos/screensaver/screensaver_controller.cc

index ad7daf98d78b8bedc85b041d4ef9b9d8e070ec7a..56aa6e267bad1a6930eaffb82bdc98b498823abf 100644

--- a/chrome/browser/chromeos/screensaver/screensaver_controller.cc

+++ b/chrome/browser/chromeos/screensaver/screensaver_controller.cc

@@ -103,7 +103,8 @@ void ScreensaverController::Observe(

switch (type) {

case chrome::NOTIFICATION_EXTENSION_INSTALLED: {

const extensions::Extension* extension =

- content::Details<const extensions::Extension>(details).ptr();

+ content::Details<const extensions::InstalledExtensionInfo>(details)->

+ extension;

// Uninstall any previously installed screensaver extensions if a new

// screensaver extension is installed.

if (extension->HasAPIPermission(extensions::APIPermission::kScreensaver))