Set up NaClChromeMainArgs number_of_cores member so apps can size threadpools appropriately

chrome/nacl/nacl_main.cc

Index: chrome/nacl/nacl_main.cc
diff --git a/chrome/nacl/nacl_main.cc b/chrome/nacl/nacl_main.cc
index 9b7a8c6b95dbf227b37a6a02799a97dcf7075d8e..5361eb42ae9fdd3970991bf613cb00abc1e19116 100644
--- a/chrome/nacl/nacl_main.cc
+++ b/chrome/nacl/nacl_main.cc
@@ -33,6 +33,10 @@ int NaClMain(const content::MainFunctionParams& parameters) {
   bool no_sandbox = parsed_command_line.HasSwitch(switches::kNoSandbox);
   platform.InitSandboxTests(no_sandbox);
 
+#if defined(OS_LINUX) || defined(OS_MACOSX)
+  int number_of_cores = sysconf(_SC_NPROCESSORS_ONLN);
+#endif
+
   if (!no_sandbox) {
     platform.EnableSandbox();
   }
@@ -40,6 +44,9 @@ int NaClMain(const content::MainFunctionParams& parameters) {
 
   if (sandbox_test_result) {
     NaClListener listener;
+#if defined(OS_LINUX) || defined(OS_MACOSX)
+    listener.set_number_of_cores(number_of_cores);

[jvoung (off chromium), 2013/04/16 18:37:38]

Still looking through the CL, but why do you have
listener.set_number_of_cores(x) here, and also call sysconf in the NaClListener
ctor?  Is the one in the ctor unnecessary?

[bsy, 2013/04/17 15:05:37]

Nope.  One in ctor is superfluous and unnecessary, especially since nacl_main.cc
declares its NaClListener object after the sandbox has been enabled.  Removed.

+#endif
     listener.Listen();
   } else {
     // This indirectly prevents the test-harness-success-cookie from being set,