Set up NaClChromeMainArgs number_of_cores member so apps can size threadpools appropriately

chrome/nacl/nacl_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include "base/command_line.h"
 #include "base/hi_res_timer_manager.h"
 #include "base/message_loop.h"
 #include "base/power_monitor/power_monitor.h"
@@ skipping 15 matching lines @@
   base::PowerMonitor power_monitor;
   HighResolutionTimerManager hi_res_timer_manager;
 
 #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)
   NaClMainPlatformDelegate platform(parameters);
 
   platform.PlatformInitialize();
   bool no_sandbox = parsed_command_line.HasSwitch(switches::kNoSandbox);
   platform.InitSandboxTests(no_sandbox);
 
+#if defined(OS_LINUX) || defined(OS_MACOSX)
+  int number_of_cores = sysconf(_SC_NPROCESSORS_ONLN);
+#endif
+
   if (!no_sandbox) {
     platform.EnableSandbox();
   }
   bool sandbox_test_result = platform.RunSandboxTests();
 
   if (sandbox_test_result) {
     NaClListener listener;
+#if defined(OS_LINUX) || defined(OS_MACOSX)
+    listener.set_number_of_cores(number_of_cores);

[jvoung (off chromium), 2013/04/16 18:37:38]

Still looking through the CL, but why do you have
listener.set_number_of_cores(x) here, and also call sysconf in the NaClListener
ctor?  Is the one in the ctor unnecessary?

[bsy, 2013/04/17 15:05:37]

Nope.  One in ctor is superfluous and unnecessary, especially since nacl_main.cc
declares its NaClListener object after the sandbox has been enabled.  Removed.

+#endif
     listener.Listen();
   } else {
     // This indirectly prevents the test-harness-success-cookie from being set,
     // as a way of communicating test failure, because the nexe won't reply.
     // TODO(jvoung): find a better way to indicate failure that doesn't
     // require waiting for a timeout.
     VLOG(1) << "Sandbox test failed: Not launching NaCl process";
   }
 #else
   NOTIMPLEMENTED() << " not implemented startup, plugin startup dialog etc.";
 #endif
 
   platform.PlatformUninitialize();
   return 0;
 }