ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc - Issue 1423793003: Optimize plane usage when primary is obscured by Overlay

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc

Issue 1423793003: Optimize plane usage when primary is obscured by Overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check that primary and Overlay formats are same Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc ('k') | ui/ozone/platform/drm/gpu/hardware_display_plane_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc

diff --git a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc b/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc

index 6cb003078c4b6280cb799c0872fc575111266c5e..2aa2f113a5c950ea640b59bb73110923b9f7d7de 100644

--- a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc

+++ b/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc

@@ -83,9 +83,15 @@ bool HardwareDisplayPlaneManagerLegacy::Commit(

}

- plane_list->plane_list.swap(plane_list->old_plane_list);

- plane_list->plane_list.clear();

- plane_list->legacy_page_flips.clear();

+ if (ret) {

+ plane_list->plane_list.swap(plane_list->old_plane_list);

+ plane_list->plane_list.clear();

+ plane_list->legacy_page_flips.clear();

+ } else {

+ ResetCurrentPlaneList(plane_list);

+ }

return ret;

}