ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc - Issue 1423793003: Optimize plane usage when primary is obscured by Overlay

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc

Issue 1423793003: Optimize plane usage when primary is obscured by Overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check that primary and Overlay formats are same Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc ('k') | ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc

diff --git a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc b/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc

index c7b93c990867984510a383f31af8cca7430a6705..33635f6d62107b12fee52c8d271c4aac5970bbb8 100644

--- a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc

+++ b/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc

@@ -65,7 +65,6 @@ bool HardwareDisplayPlaneManagerAtomic::Commit(

} else {

plane_list->plane_list.swap(plane_list->old_plane_list);

}

- plane_list->plane_list.clear();

uint32_t flags = 0;

if (test_only) {

@@ -78,8 +77,11 @@ bool HardwareDisplayPlaneManagerAtomic::Commit(

crtcs.size(),

base::Bind(&AtomicPageFlipCallback, crtcs))) {

PLOG(ERROR) << "Failed to commit properties";

+ ResetCurrentPlaneList(plane_list);

return false;

}

+ plane_list->plane_list.clear();

plane_list->atomic_property_set.reset(drmModeAtomicAlloc());

return true;

}