Add more cases to bleed GM and more variants

Add more cases to bleed GM and more variants

Committed: https://skia.googlesource.com/skia/+/9003d1e7384e174e26c37116b6105a63317d84a1

[bsalomon, 2015-10-23 14:53:39]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2015-10-23 14:53:40]

Reveals a bunch of bugs.

[bsalomon, 2015-10-23 14:53:50]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 14:53:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423793002/20001

[commit-bot: I haz the power, 2015-10-23 15:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 15:03:55]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-10-23 16:53:58]

lgtm

https://codereview.chromium.org/1423793002/diff/20001/gm/bleed.cpp
File gm/bleed.cpp (right):

https://codereview.chromium.org/1423793002/diff/20001/gm/bleed.cpp#newcode96
gm/bleed.cpp:96: 
// Make the A8 texture:
// 
// 1 1 1   ...   1 1 1
// 1 0 0   ...   0 0 1
// 1 0 .75 ...  .5 0 1
// . . .   ...   . . .
// 1 0 .5  ... .75 0 1
// 1 0 0   ...   0 0 1
// 1 1 1   ...   1 1 1

?

https://codereview.chromium.org/1423793002/diff/20001/gm/bleed.cpp#newcode391
gm/bleed.cpp:391: static const int kCol5X = 6*kBlockSpacing + 5*kBlockSize;
Is kWidth used anywhere anymore ?

https://codereview.chromium.org/1423793002/diff/20001/gm/bleed.cpp#newcode417
gm/bleed.cpp:417: DEF_GM( return new BleedGM(kUseAlphaImage_BleedTest); )
Should we have a bug ?

[bsalomon, 2015-10-23 17:57:05]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-10-23 17:57:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1423793002/#ps40001
(title: "Address comment")

[commit-bot: I haz the power, 2015-10-23 17:57:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423793002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423793002/40001

[bsalomon, 2015-10-23 17:57:11]

https://codereview.chromium.org/1423793002/diff/20001/gm/bleed.cpp
File gm/bleed.cpp (right):

https://codereview.chromium.org/1423793002/diff/20001/gm/bleed.cpp#newcode96
gm/bleed.cpp:96: 
On 2015/10/23 16:53:58, robertphillips wrote:
> // Make the A8 texture:
> // 
> // 1 1 1   ...   1 1 1
> // 1 0 0   ...   0 0 1
> // 1 0 .75 ...  .5 0 1
> // . . .   ...   . . .
> // 1 0 .5  ... .75 0 1
> // 1 0 0   ...   0 0 1
> // 1 1 1   ...   1 1 1
> 
> ?

Done.

https://codereview.chromium.org/1423793002/diff/20001/gm/bleed.cpp#newcode391
gm/bleed.cpp:391: static const int kCol5X = 6*kBlockSpacing + 5*kBlockSize;
On 2015/10/23 16:53:58, robertphillips wrote:
> Is kWidth used anywhere anymore ?

Yep

https://codereview.chromium.org/1423793002/diff/20001/gm/bleed.cpp#newcode417
gm/bleed.cpp:417: DEF_GM( return new BleedGM(kUseAlphaImage_BleedTest); )
On 2015/10/23 16:53:58, robertphillips wrote:
> Should we have a bug ?

I'm looking into it now... if I don't have a quick fix will file a bug

[commit-bot: I haz the power, 2015-10-23 18:13:04]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9003d1e7384e174e26c37116b6105a63317d84a1