Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 1423713009: EDK: Move ref counting classes to mojo/edk/util. (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Move ref counting classes to mojo/edk/util. (In particular, RefPtr<T> and RefCountedThreadSafe<T>.) The embedder API will use RefPtr<T> in its interface (replacing the current use of scoped_refptr<T>), and we don't want to expose things in mojo/edk/system to embedders. Note: As a general rule, in .cc files in mojo/edk/system, I always used |using mojo::util::RefPtr| (since |util::RefPtr| is very tiresome; I did it everywhere for consistency). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/6a1f1a8187d874da20c5daf21e438c8c8492ec91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -1398 lines) Patch
M mojo/edk/embedder/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/embedder/embedder.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M mojo/edk/embedder/system_impl_private_entrypoints.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 4 chunks +3 lines, -7 lines 0 comments Download
M mojo/edk/system/channel.h View 9 chunks +17 lines, -15 lines 0 comments Download
M mojo/edk/system/channel.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/channel_endpoint.h View 6 chunks +11 lines, -10 lines 0 comments Download
M mojo/edk/system/channel_endpoint.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/channel_endpoint_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/channel_endpoint_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/channel_manager.h View 7 chunks +10 lines, -10 lines 0 comments Download
M mojo/edk/system/channel_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/channel_manager_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/channel_test_base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/channel_test_base.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/channel_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/core.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/core.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe.h View 6 chunks +8 lines, -8 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 4 chunks +8 lines, -8 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 4 chunks +8 lines, -8 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 9 chunks +13 lines, -10 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/system/endpoint_relayer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/endpoint_relayer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/endpoint_relayer_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/system/handle_table.h View 5 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/system/handle_table.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/incoming_endpoint.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/system/incoming_endpoint.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/ipc_support.h View 4 chunks +3 lines, -4 lines 0 comments Download
M mojo/edk/system/ipc_support.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/local_data_pipe_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/master_connection_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe.h View 5 chunks +9 lines, -10 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 6 chunks +11 lines, -10 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_endpoint.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_perftest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_test_utils.h View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.h View 4 chunks +5 lines, -4 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/proxy_message_pipe_endpoint.h View 4 chunks +5 lines, -4 lines 0 comments Download
M mojo/edk/system/proxy_message_pipe_endpoint.cc View 1 chunk +2 lines, -0 lines 0 comments Download
D mojo/edk/system/ref_counted.h View 1 chunk +0 lines, -123 lines 0 comments Download
D mojo/edk/system/ref_counted_internal.h View 1 chunk +0 lines, -101 lines 0 comments Download
D mojo/edk/system/ref_counted_perftest.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D mojo/edk/system/ref_counted_unittest.cc View 1 chunk +0 lines, -610 lines 0 comments Download
D mojo/edk/system/ref_ptr.h View 1 chunk +0 lines, -233 lines 0 comments Download
D mojo/edk/system/ref_ptr_internal.h View 1 chunk +0 lines, -40 lines 0 comments Download
M mojo/edk/system/remote_consumer_data_pipe_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/remote_consumer_data_pipe_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/edk/system/remote_producer_data_pipe_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/remote_producer_data_pipe_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 4 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/simple_dispatcher_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/waiter_test_utils.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/waiter_test_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/util/BUILD.gn View 1 chunk +41 lines, -0 lines 0 comments Download
A + mojo/edk/util/ref_counted.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + mojo/edk/util/ref_counted_internal.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/edk/util/ref_counted_perftest.cc View 3 chunks +11 lines, -11 lines 0 comments Download
A + mojo/edk/util/ref_counted_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + mojo/edk/util/ref_ptr.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + mojo/edk/util/ref_ptr_internal.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 1 month ago (2015-10-30 22:00:19 UTC) #1
vardhan
lgtm
5 years, 1 month ago (2015-10-30 22:07:35 UTC) #2
viettrungluu
5 years, 1 month ago (2015-10-30 22:18:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a1f1a8187d874da20c5daf21e438c8c8492ec91 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698