Issue 14237003: Rename SpecialStoragePolicy::IsInstalledApp() to CanQueryDiskSize()

Issue 14237003: Rename SpecialStoragePolicy::IsInstalledApp() to CanQueryDiskSize() (Closed)

Created:
7 years, 8 months ago by kinuko

Modified:
7 years, 8 months ago

Reviewers:
michaeln, asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename SpecialStoragePolicy::IsInstalledApp() to CanQueryDiskSize() To fix layering leakage issue. BUG=none TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194748

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -33 lines)			Patch
M	chrome/browser/extensions/extension_special_storage_policy.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_special_storage_policy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_special_storage_policy_unittest.cc	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/mock_extension_special_storage_policy.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/mock_extension_special_storage_policy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/quota/mock_special_storage_policy.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	webkit/quota/mock_special_storage_policy.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/quota/quota_manager.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/quota/quota_manager.cc	View	1 2	5 chunks	+10 lines, -9 lines	0 comments	Download
M	webkit/quota/quota_manager_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/quota/special_storage_policy.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

kinuko

A follow-up renaming patch for https://chromiumcodereview.appspot.com/13994010/ (simple rename only). Can you take a look? Thanks,

7 years, 8 months ago (2013-04-16 07:50:04 UTC) #1

michaeln

https://chromiumcodereview.appspot.com/14237003/diff/8005/webkit/quota/quota_manager.cc File webkit/quota/quota_manager.cc (right): https://chromiumcodereview.appspot.com/14237003/diff/8005/webkit/quota/quota_manager.cc#newcode188 webkit/quota/quota_manager.cc:188: int64 CalculateQuotaForInstalledApp( maybe change the name of this method ...

7 years, 8 months ago (2013-04-16 21:21:04 UTC) #3

kinuko

7 years, 8 months ago (2013-04-17 04:33:38 UTC) #4

kinuko

asargent@: Can you take a quick look for chrome/browser/extensions owners review? Thanks!

7 years, 8 months ago (2013-04-17 04:35:16 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/14237003/18001

7 years, 8 months ago (2013-04-18 00:58:59 UTC) #7

kinuko

7 years, 8 months ago (2013-04-18 01:52:53 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r194748 (presubmit successful).

Expand Messages | Collapse Messages