chrome/browser/extensions/extension_special_storage_policy_unittest.cc - Issue 14237003: Rename SpecialStoragePolicy::IsInstalledApp() to CanQueryDiskSize()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

Issue 14237003: Rename SpecialStoragePolicy::IsInstalledApp() to CanQueryDiskSize() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_special_storage_policy.cc ('k') | chrome/browser/extensions/mock_extension_special_storage_policy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

diff --git a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

index c94984536cf3ccb05e9d3e19d62e45bd9836a29c..ebd57878ed7b6731a95ff9c09606b6668888cd40 100644

--- a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

+++ b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

@@ -233,7 +233,7 @@ TEST_F(ExtensionSpecialStoragePolicyTest, AppWithUnlimitedStorage) {

EXPECT_FALSE(policy_->IsStorageUnlimited(GURL("https://bar.wildcards/")));

}

-TEST_F(ExtensionSpecialStoragePolicyTest, IsInstalled) {

+TEST_F(ExtensionSpecialStoragePolicyTest, CanQueryDiskSize) {

const GURL kHttpUrl("http://foo");

const GURL kExtensionUrl("chrome-extension://bar");

scoped_refptr<Extension> regular_app(CreateRegularApp());

@@ -243,11 +243,11 @@ TEST_F(ExtensionSpecialStoragePolicyTest, IsInstalled) {

policy_->GrantRightsForExtension(protected_app);

policy_->GrantRightsForExtension(unlimited_app);

- EXPECT_FALSE(policy_->IsInstalledApp(kHttpUrl));

- EXPECT_FALSE(policy_->IsInstalledApp(kExtensionUrl));

- EXPECT_TRUE(policy_->IsInstalledApp(regular_app->url()));

- EXPECT_TRUE(policy_->IsInstalledApp(protected_app->url()));

- EXPECT_TRUE(policy_->IsInstalledApp(unlimited_app->url()));

+ EXPECT_FALSE(policy_->CanQueryDiskSize(kHttpUrl));

+ EXPECT_FALSE(policy_->CanQueryDiskSize(kExtensionUrl));

+ EXPECT_TRUE(policy_->CanQueryDiskSize(regular_app->url()));

+ EXPECT_TRUE(policy_->CanQueryDiskSize(protected_app->url()));

+ EXPECT_TRUE(policy_->CanQueryDiskSize(unlimited_app->url()));

}

TEST_F(ExtensionSpecialStoragePolicyTest, OverlappingApps) {