Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8992)

Unified Diff: chrome/browser/ui/toolbar/media_router_action.cc

Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix JS. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/media_router_action.cc
diff --git a/chrome/browser/ui/toolbar/media_router_action.cc b/chrome/browser/ui/toolbar/media_router_action.cc
index 34877266f464fa542c6b46dc2c964bd0a42ed25f..2b9f59bd9eb29946acb8a6d103fc64c22adcc4c9 100644
--- a/chrome/browser/ui/toolbar/media_router_action.cc
+++ b/chrome/browser/ui/toolbar/media_router_action.cc
@@ -4,11 +4,13 @@
#include "chrome/browser/ui/toolbar/media_router_action.h"
+#include "base/metrics/user_metrics.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/media/router/issue.h"
#include "chrome/browser/media/router/media_route.h"
#include "chrome/browser/media/router/media_router.h"
#include "chrome/browser/media/router/media_router_factory.h"
+#include "chrome/browser/media/router/media_router_metrics.h"
#include "chrome/browser/media/router/media_router_mojo_impl.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
@@ -130,9 +132,14 @@ ui::MenuModel* MediaRouterAction::GetContextMenu() {
}
bool MediaRouterAction::ExecuteAction(bool by_user) {
+ base::RecordAction(base::UserMetricsAction("MediaRouter_Icon_Click"));
+
GetMediaRouterDialogController()->ShowMediaRouterDialog();
- if (GetPlatformDelegate())
- GetPlatformDelegate()->CloseOverflowMenuIfOpen();
+ if (GetPlatformDelegate()) {
+ media_router::MediaRouterMetrics::RecordMediaRouterDialogOrigin(
+ GetPlatformDelegate()->CloseOverflowMenuIfOpen() ?
+ media_router::OVERFLOW_MENU : media_router::TOOLBAR);
+ }
return true;
}

Powered by Google App Engine
This is Rietveld 408576698