chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.mm - Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.mm

Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix JS. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.h ('k') | chrome/browser/ui/toolbar/media_router_action.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.mm b/chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.mm

index df034ace0213fbcdb30b299e249f346d31b196ad..81927272faddb4185fececdbcbb4252ae0523a2c 100644

--- a/chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.mm

+++ b/chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.mm

@@ -28,7 +28,7 @@ MediaRouterActionPlatformDelegateCocoa::

~MediaRouterActionPlatformDelegateCocoa() {

}

-void MediaRouterActionPlatformDelegateCocoa::CloseOverflowMenuIfOpen() {

+bool MediaRouterActionPlatformDelegateCocoa::CloseOverflowMenuIfOpen() {

// TODO(apacible): This should be factored to share code with extension

// actions.

WrenchMenuController* wrenchMenuController =

@@ -36,6 +36,9 @@ void MediaRouterActionPlatformDelegateCocoa::CloseOverflowMenuIfOpen() {

browserWindowControllerForWindow:

browser_->window()->GetNativeWindow()]

toolbarController] wrenchMenuController];

- if ([wrenchMenuController isMenuOpen])

- [wrenchMenuController cancel];

+ if (![wrenchMenuController isMenuOpen])

+ return false;

+ [wrenchMenuController cancel];

+ return true;

}