[Media Router] Add P1 UMA metrics for Media Router.

chrome/browser/ui/toolbar/media_router_action.cc

Index: chrome/browser/ui/toolbar/media_router_action.cc
diff --git a/chrome/browser/ui/toolbar/media_router_action.cc b/chrome/browser/ui/toolbar/media_router_action.cc
index 34877266f464fa542c6b46dc2c964bd0a42ed25f..f75d4ea06044ca983fa2a811eb850f16a7c3acc8 100644
--- a/chrome/browser/ui/toolbar/media_router_action.cc
+++ b/chrome/browser/ui/toolbar/media_router_action.cc
@@ -4,11 +4,14 @@
 
 #include "chrome/browser/ui/toolbar/media_router_action.h"
 
+#include "base/metrics/histogram.h"

[Ilya Sherman, 2015/10/23 20:40:22]

nit: Please include histogram_macros instead

[apacible, 2015/10/23 22:52:55]

Done (moved to media_router_metrics).

+#include "base/metrics/user_metrics.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/media/router/issue.h"
 #include "chrome/browser/media/router/media_route.h"
 #include "chrome/browser/media/router/media_router.h"
 #include "chrome/browser/media/router/media_router_factory.h"
+#include "chrome/browser/media/router/media_router_metrics_enums.h"
 #include "chrome/browser/media/router/media_router_mojo_impl.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ -130,9 +133,20 @@ ui::MenuModel* MediaRouterAction::GetContextMenu() {
 }
 
 bool MediaRouterAction::ExecuteAction(bool by_user) {
+  base::RecordAction(base::UserMetricsAction("MediaRouter_Icon_Click"));
+
   GetMediaRouterDialogController()->ShowMediaRouterDialog();
-  if (GetPlatformDelegate())
-    GetPlatformDelegate()->CloseOverflowMenuIfOpen();
+  if (GetPlatformDelegate()) {
+    if (GetPlatformDelegate()->CloseOverflowMenuIfOpen()) {
+      UMA_HISTOGRAM_ENUMERATION("MediaRouter.Icon.Click.Location",
+                                media_router::OVERFLOW_MENU,
+                                media_router::TOTAL_COUNT);
+    } else {
+      UMA_HISTOGRAM_ENUMERATION("MediaRouter.Icon.Click.Location",
+                          media_router::TOOLBAR,
+                          media_router::TOTAL_COUNT);

[Ilya Sherman, 2015/10/23 20:40:22]

nit: Please create a wrapper function for logging to this one histogram, that
you'd call as something like
RecordMediaRouterDialogOrigin(media_router::TOOLBAR);

[apacible, 2015/10/23 22:52:54]

Done.

+    }
+  }
   return true;
 }