[Media Router] Add P1 UMA metrics for Media Router.

chrome/browser/ui/toolbar/media_router_action.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/toolbar/media_router_action.h"
 
+#include "base/metrics/histogram.h"

[Ilya Sherman, 2015/10/23 20:40:22]

nit: Please include histogram_macros instead

[apacible, 2015/10/23 22:52:55]

Done (moved to media_router_metrics).

+#include "base/metrics/user_metrics.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/media/router/issue.h"
 #include "chrome/browser/media/router/media_route.h"
 #include "chrome/browser/media/router/media_router.h"
 #include "chrome/browser/media/router/media_router_factory.h"
+#include "chrome/browser/media/router/media_router_metrics_enums.h"
 #include "chrome/browser/media/router/media_router_mojo_impl.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
 #include "chrome/browser/ui/toolbar/media_router_action_platform_delegate.h"
 #include "chrome/browser/ui/toolbar/toolbar_action_view_delegate.h"
 #include "chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h"
 #include "chrome/grit/generated_resources.h"
 #include "grit/theme_resources.h"
@@ skipping 101 matching lines @@
 
 gfx::NativeView MediaRouterAction::GetPopupNativeView() {
   return nullptr;
 }
 
 ui::MenuModel* MediaRouterAction::GetContextMenu() {
   return contextual_menu_.menu_model();
 }
 
 bool MediaRouterAction::ExecuteAction(bool by_user) {
+  base::RecordAction(base::UserMetricsAction("MediaRouter_Icon_Click"));
+
   GetMediaRouterDialogController()->ShowMediaRouterDialog();
-  if (GetPlatformDelegate())
-    GetPlatformDelegate()->CloseOverflowMenuIfOpen();
+  if (GetPlatformDelegate()) {
+    if (GetPlatformDelegate()->CloseOverflowMenuIfOpen()) {
+      UMA_HISTOGRAM_ENUMERATION("MediaRouter.Icon.Click.Location",
+                                media_router::OVERFLOW_MENU,
+                                media_router::TOTAL_COUNT);
+    } else {
+      UMA_HISTOGRAM_ENUMERATION("MediaRouter.Icon.Click.Location",
+                          media_router::TOOLBAR,
+                          media_router::TOTAL_COUNT);

[Ilya Sherman, 2015/10/23 20:40:22]

nit: Please create a wrapper function for logging to this one histogram, that
you'd call as something like
RecordMediaRouterDialogOrigin(media_router::TOOLBAR);

[apacible, 2015/10/23 22:52:54]

Done.

+    }
+  }
   return true;
 }
 
 void MediaRouterAction::UpdateState() {
   if (delegate_)
     delegate_->UpdateState();
 }
 
 bool MediaRouterAction::DisabledClickOpensMenu() const {
   return false;
@@ skipping 80 matching lines @@
   if (issue_) {
     if (issue_->severity() == media_router::Issue::FATAL)
       return &media_router_error_icon_;
     if (issue_->severity() == media_router::Issue::WARNING)
       return &media_router_warning_icon_;
   }
 
   return has_local_route_ ?
       &media_router_active_icon_ : &media_router_idle_icon_;
 }