chrome/browser/media/router/media_router_dialog_controller.cc - Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/media_router_dialog_controller.cc

Issue 1423683002: [Media Router] Add P1 UMA metrics for Media Router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/media_router.gypi ('k') | chrome/browser/media/router/media_router_metrics_enums.h » ('j') | chrome/browser/ui/toolbar/media_router_action.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/media_router_dialog_controller.cc

diff --git a/chrome/browser/media/router/media_router_dialog_controller.cc b/chrome/browser/media/router/media_router_dialog_controller.cc

index 9efe8b98f0c2fb49839eb762bfc925d6a82833c0..e0bcef69cb78a428c73fa36d7123521c0787aac0 100644

--- a/chrome/browser/media/router/media_router_dialog_controller.cc

+++ b/chrome/browser/media/router/media_router_dialog_controller.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/media/router/media_router_dialog_controller.h"

+#include "base/metrics/histogram.h"

+#include "chrome/browser/media/router/media_router_metrics_enums.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_contents_delegate.h"

@@ -85,6 +87,10 @@ bool MediaRouterDialogController::ShowMediaRouterDialogForPresentation(

// Show the initiator holding the existing media router dialog.

ActivateInitiatorWebContents();

+ UMA_HISTOGRAM_ENUMERATION("MediaRouter.Icon.Click.Location",

+ media_router::PAGE,

+ media_router::TOTAL_COUNT);

return true;

}