Change ScopedPtr(Hash)Map to make qualified calls to ignore_result().

Change ScopedPtr(Hash)Map to make qualified calls to ignore_result().

Currently, ignore_result() calls in ScopedPtr(Hash)Map are unqualified.
If the mapped_type is in a namespace containing an ignore_result()
function, ADL causes that function to be considered in overload
resolution. If the ignore_result() in that namespace is a function
template, both ignore_result() functions are equally ranked in overload
resolution, resulting in the ignore_result() call being ambiguous. This
change avoids this problem by making qualified calls to ignore_result()
in ScopedPtr(Hash)Map.

Committed: https://crrev.com/40d9ba69acc929515cd23196022edfd4b49ed9a0
Cr-Commit-Position: refs/heads/master@{#357298}

[Sam McNally, 2015-10-29 02:40:49]

Description was changed from

==========
Change ScopedPtr(Hash)Map to make qualified calls to ignore_result().

Currently, ignore_result() calls in ScopedPtr(Hash)Map are unqualified.
If the mapped_type is in a namespace containing an ignore_result()
function, ADL causes that function to be considered in overload
resolution. If the ignore_result() in that namespace is a function
template, both ignore_result() functions are equally ranked in overload
resolution, resulting in the ignore_result() call being ambiguous. This
change avoids this problem by making qualified calls to ignore_result()
in ScopedPtr(Hash)Map.
==========

to

==========
Change ScopedPtr(Hash)Map to make qualified calls to ignore_result().

Currently, ignore_result() calls in ScopedPtr(Hash)Map are unqualified.
If the mapped_type is in a namespace containing an ignore_result()
function, ADL causes that function to be considered in overload
resolution. If the ignore_result() in that namespace is a function
template, both ignore_result() functions are equally ranked in overload
resolution, resulting in the ignore_result() call being ambiguous. This
change avoids this problem by making qualified calls to ignore_result()
in ScopedPtr(Hash)Map.
==========

[Sam McNally, 2015-10-29 03:05:42]

sammc@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-10-29 17:48:39]

https://codereview.chromium.org/1423663010/diff/1/base/containers/scoped_ptr_...
File base/containers/scoped_ptr_hash_map_unittest.cc (right):

https://codereview.chromium.org/1423663010/diff/1/base/containers/scoped_ptr_...
base/containers/scoped_ptr_hash_map_unittest.cc:12: namespace
namespace_with_ignore_result {
can you whitespace better here?

1 whitespace above this. one before the closing }. put a //  namespace
namespace_with_ignore_result on the closing }.

https://codereview.chromium.org/1423663010/diff/1/base/containers/scoped_ptr_...
File base/containers/scoped_ptr_map_unittest.cc (right):

https://codereview.chromium.org/1423663010/diff/1/base/containers/scoped_ptr_...
base/containers/scoped_ptr_map_unittest.cc:18: namespace
namespace_with_ignore_result {
ditto

[Sam McNally, 2015-10-30 00:18:40]

https://codereview.chromium.org/1423663010/diff/1/base/containers/scoped_ptr_...
File base/containers/scoped_ptr_hash_map_unittest.cc (right):

https://codereview.chromium.org/1423663010/diff/1/base/containers/scoped_ptr_...
base/containers/scoped_ptr_hash_map_unittest.cc:12: namespace
namespace_with_ignore_result {
On 2015/10/29 17:48:39, danakj wrote:
> can you whitespace better here?
> 
> 1 whitespace above this. one before the closing }. put a //  namespace
> namespace_with_ignore_result on the closing }.

Done.

https://codereview.chromium.org/1423663010/diff/1/base/containers/scoped_ptr_...
File base/containers/scoped_ptr_map_unittest.cc (right):

https://codereview.chromium.org/1423663010/diff/1/base/containers/scoped_ptr_...
base/containers/scoped_ptr_map_unittest.cc:18: namespace
namespace_with_ignore_result {
On 2015/10/29 17:48:39, danakj wrote:
> ditto

Done.

[danakj, 2015-10-30 17:44:13]

LGTM

[Sam McNally, 2015-11-02 01:01:09]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2015-11-02 01:01:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423663010/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423663010/20001

[commit-bot: I haz the power, 2015-11-02 02:22:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-02 02:22:48]

Patchset 2 (id:??) landed as
https://crrev.com/40d9ba69acc929515cd23196022edfd4b49ed9a0
Cr-Commit-Position: refs/heads/master@{#357298}