Change ScopedPtr(Hash)Map to make qualified calls to ignore_result().

base/containers/scoped_ptr_hash_map_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/containers/scoped_ptr_hash_map.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 namespace {
+namespace namespace_with_ignore_result {

[danakj, 2015/10/29 17:48:39]

can you whitespace better here?

1 whitespace above this. one before the closing }. put a //  namespace
namespace_with_ignore_result on the closing }.

[Sam McNally, 2015/10/30 00:18:40]

Done.

+
+class Value {};
+
+template <typename T>
+void ignore_result(const T&) {}
+}
 
 struct DeleteCounter {
  public:
   DeleteCounter() {}
   ~DeleteCounter() { g_delete_count++; }
 
   static void ResetCounter() { g_delete_count = 0; }
   static int delete_count() { return g_delete_count; }
 
  private:
@@ skipping 52 matching lines @@
     map.set(key, scoped_ptr<DeleteCounter, CountingDeleter>(new DeleteCounter));
     map.set(key, scoped_ptr<DeleteCounter, CountingDeleter>(new DeleteCounter));
     map.set(key, scoped_ptr<DeleteCounter, CountingDeleter>(new DeleteCounter));
     EXPECT_EQ(2, DeleteCounter::delete_count());
     EXPECT_EQ(2, CountingDeleter::count());
   }
   EXPECT_EQ(3, DeleteCounter::delete_count());
   EXPECT_EQ(3, CountingDeleter::count());
 }
 
+// Test that using a value type from a namespace containing an ignore_result
+// function compiles correctly.
+TEST(ScopedPtrHashMapTest, IgnoreResultCompile) {
+  ScopedPtrHashMap<int, scoped_ptr<namespace_with_ignore_result::Value>>
+      scoped_map;
+  scoped_map.add(1, make_scoped_ptr(new namespace_with_ignore_result::Value));
+}
+
 }  // namespace
 }  // namespace base