Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: src/parameter-initializer-rewriter.cc

Issue 1423613002: Fix eval calls in initializers of arrow function parameters (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/scopes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parameter-initializer-rewriter.cc
diff --git a/src/parameter-initializer-rewriter.cc b/src/parameter-initializer-rewriter.cc
index 28f741c1f6238887a1cad6d185344b6aec2ecf62..2d6417ab19644a63679ad1579dfcd57865e57794 100644
--- a/src/parameter-initializer-rewriter.cc
+++ b/src/parameter-initializer-rewriter.cc
@@ -75,6 +75,9 @@ void RewriteParameterInitializerScope(uintptr_t stack_limit,
Scope* new_scope) {
Rewriter rewriter(stack_limit, initializer, old_scope, new_scope);
rewriter.Run();
+
+ // Note that we can't safely un-set the calls_eval bit on the old scope.
+ if (old_scope->calls_eval()) new_scope->RecordEvalCall();
rossberg 2015/10/22 12:21:28 I wonder about all the other scope flags. Do we kn
}
« no previous file with comments | « no previous file | src/scopes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698