Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: src/parameter-initializer-rewriter.cc

Issue 1423613002: Fix eval calls in initializers of arrow function parameters (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/scopes.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/parameter-initializer-rewriter.h" 5 #include "src/parameter-initializer-rewriter.h"
6 6
7 #include "src/ast.h" 7 #include "src/ast.h"
8 #include "src/ast-expression-visitor.h" 8 #include "src/ast-expression-visitor.h"
9 #include "src/scopes.h" 9 #include "src/scopes.h"
10 10
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 68
69 69
70 } // anonymous namespace 70 } // anonymous namespace
71 71
72 72
73 void RewriteParameterInitializerScope(uintptr_t stack_limit, 73 void RewriteParameterInitializerScope(uintptr_t stack_limit,
74 Expression* initializer, Scope* old_scope, 74 Expression* initializer, Scope* old_scope,
75 Scope* new_scope) { 75 Scope* new_scope) {
76 Rewriter rewriter(stack_limit, initializer, old_scope, new_scope); 76 Rewriter rewriter(stack_limit, initializer, old_scope, new_scope);
77 rewriter.Run(); 77 rewriter.Run();
78
79 // Note that we can't safely un-set the calls_eval bit on the old scope.
80 if (old_scope->calls_eval()) new_scope->RecordEvalCall();
rossberg 2015/10/22 12:21:28 I wonder about all the other scope flags. Do we kn
78 } 81 }
79 82
80 83
81 } // namespace internal 84 } // namespace internal
82 } // namespace v8 85 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/scopes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698