Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1423533003: Gives MojomFile a slice in order to store its imports in a specified order. (Closed)

Created:
5 years, 1 month ago by rudominer
Modified:
5 years, 1 month ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Gives MojomFile a slice in order to store its imports in a specified order. We want to be able to store both the specified order of the imports and also a map from specified short name to canonical long name. Also makes clear the different roles of the two names and which is used where. R=azani@chromium.org, azani BUG=#461 Committed: https://chromium.googlesource.com/external/mojo/+/90ece36df437aa8d3f6270d13eedc061aafb0ede

Patch Set 1 #

Patch Set 2 : Improves comment. #

Patch Set 3 : Improves comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -33 lines) Patch
M mojom/mojom_parser/mojom/mojom_descriptor.go View 1 2 7 chunks +49 lines, -23 lines 0 comments Download
M mojom/mojom_parser/mojom/scopes.go View 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/mojom/types.go View 3 chunks +3 lines, -3 lines 0 comments Download
M mojom/mojom_parser/parser/parse_driver.go View 2 chunks +3 lines, -3 lines 0 comments Download
M mojom/mojom_parser/parser/parse_driver_test.go View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
rudominer
ptal
5 years, 1 month ago (2015-10-27 22:04:08 UTC) #6
azani
lgtm
5 years, 1 month ago (2015-10-27 22:38:28 UTC) #7
rudominer
5 years, 1 month ago (2015-10-27 22:56:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
90ece36df437aa8d3f6270d13eedc061aafb0ede (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698