mojom/mojom_parser/mojom/scopes.go - Issue 1423533003: Gives MojomFile a slice in order to store its imports in a specified order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/mojom_parser/mojom/scopes.go

Issue 1423533003: Gives MojomFile a slice in order to store its imports in a specified order. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Improves comment. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojom/mojom_parser/mojom/scopes.go

diff --git a/mojom/mojom_parser/mojom/scopes.go b/mojom/mojom_parser/mojom/scopes.go

index e7b8afbba575b708aecb30be65ce1740ddb6700c..346908fb4805d094c25efd436a10d0708a8dfd91 100644

--- a/mojom/mojom_parser/mojom/scopes.go

+++ b/mojom/mojom_parser/mojom/scopes.go

@@ -181,7 +181,7 @@ func (s *Scope) String() string {

}

fileNameString := ""

if s.file != nil {

- fileNameString = fmt.Sprintf(" in %s", s.file.FileName)

+ fileNameString = fmt.Sprintf(" in %s", s.file.CanonicalFileName)

}

return fmt.Sprintf("%s %s%s", s.kind, s.shortName, fileNameString)

}

« no previous file with comments | « mojom/mojom_parser/mojom/mojom_descriptor.go ('k') | mojom/mojom_parser/mojom/types.go » ('j') | no next file with comments »