Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1423493006: MIPS: Fix 'MIPS:r6 compact branch optimization.' (Closed)

Created:
5 years, 1 month ago by balazs.kilvady
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'MIPS:r6 compact branch optimization.' Jic and jialc compact branch ops are fixed as they does not have 'forbidden slot' restriction. Also COP1 branches (CTI instructions) added to IsForbiddenAfterBranchInstr(). TEST=cctest/test-disasm-mips/Type0 BUG= Committed: https://crrev.com/6993cd0de5ef7edd437c2e45c958d079f27bdd59 Cr-Commit-Position: refs/heads/master@{#31922}

Patch Set 1 #

Patch Set 2 : Fix jic and jialc. #

Patch Set 3 : Rebase, merge cctest/test-disasm-mips/Type0 fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -44 lines) Patch
M src/mips/assembler-mips.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 2 3 chunks +2 lines, -6 lines 0 comments Download
M src/mips/constants-mips.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/mips/disasm-mips.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 1 2 7 chunks +46 lines, -34 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
balazs.kilvady
5 years, 1 month ago (2015-11-09 13:34:28 UTC) #3
paul.l...
LGTM, however, please add the failing TEST= names, and maybe add a brief text summary ...
5 years, 1 month ago (2015-11-09 16:20:32 UTC) #5
balazs.kilvady
5 years, 1 month ago (2015-11-09 18:16:20 UTC) #7
Ilija.Pavlovic1
lgtm
5 years, 1 month ago (2015-11-10 08:39:55 UTC) #9
balazs.kilvady
Ilija's cctest patch has been merged.
5 years, 1 month ago (2015-11-10 16:15:38 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423493006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423493006/40001
5 years, 1 month ago (2015-11-10 16:16:06 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-10 16:54:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423493006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423493006/40001
5 years, 1 month ago (2015-11-10 17:13:55 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-10 17:15:35 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 17:16:19 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6993cd0de5ef7edd437c2e45c958d079f27bdd59
Cr-Commit-Position: refs/heads/master@{#31922}

Powered by Google App Engine
This is Rietveld 408576698