src/mips/disasm-mips.cc - Issue 1423493006: MIPS: Fix 'MIPS:r6 compact branch optimization.'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/disasm-mips.cc

Issue 1423493006: MIPS: Fix 'MIPS:r6 compact branch optimization.' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase, merge cctest/test-disasm-mips/Type0 fix. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/disasm-mips.cc

diff --git a/src/mips/disasm-mips.cc b/src/mips/disasm-mips.cc

index 512e6f3f86db8db4fe0e9be4e4a6353f617b772e..5502f4170cc995a35cab6cbb63c7798ef6952ced 100644

--- a/src/mips/disasm-mips.cc

+++ b/src/mips/disasm-mips.cc

@@ -1435,9 +1435,9 @@ void Decoder::DecodeTypeImmediate(Instruction* instr) {

break;

case POP76:

if (instr->RsValue() == JIALC) {

- Format(instr, "jialc 'rt, 'imm16x");

+ Format(instr, "jialc 'rt, 'imm16s");

} else {

- Format(instr, "bnezc 'rs, 'imm21x -> 'imm21p4s2");

+ Format(instr, "bnezc 'rs, 'imm21s -> 'imm21p4s2");

}

break;

// ------------- Arithmetic instructions.

« no previous file with comments | « src/mips/constants-mips.cc ('k') | test/cctest/test-disasm-mips.cc » ('j') | no next file with comments »