Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: chrome/browser/ui/views/location_bar/ev_bubble_view.h

Issue 1423263004: [MD] Use programmatic rendering for omnibox chips (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/ev_bubble_view.h
diff --git a/chrome/browser/ui/views/location_bar/ev_bubble_view.h b/chrome/browser/ui/views/location_bar/ev_bubble_view.h
index aae2353fe9c8eb4b6790b514e62c5222129c78b6..88c33fc4c666cc20d969909fe166e9c6477d1d35 100644
--- a/chrome/browser/ui/views/location_bar/ev_bubble_view.h
+++ b/chrome/browser/ui/views/location_bar/ev_bubble_view.h
@@ -24,6 +24,8 @@ class EVBubbleView : public IconLabelBubbleView {
bool OnMousePressed(const ui::MouseEvent& event) override;
void OnMouseReleased(const ui::MouseEvent& event) override;
void OnGestureEvent(ui::GestureEvent* event) override;
+ SkColor GetTextColor() const override;
+ SkColor GetBorderColor() const override;
// Returns what the minimum size would be if the label text were |text|.
gfx::Size GetMinimumSizeForLabelText(const base::string16& text) const;
@@ -32,6 +34,10 @@ class EVBubbleView : public IconLabelBubbleView {
// Returns what the minimum size would be if the preferred size were |size|.
gfx::Size GetMinimumSizeForPreferredSize(gfx::Size size) const;
+ // TODO(estade): this should be gleaned from the theme instead of hardcoded in
+ // location_bar_view.cc and cached here.
+ SkColor text_color_;
+
PageInfoHelper page_info_helper_;
DISALLOW_COPY_AND_ASSIGN(EVBubbleView);

Powered by Google App Engine
This is Rietveld 408576698