Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6974)

Unified Diff: chrome/browser/ui/views/location_bar/content_setting_image_view.h

Issue 1423263004: [MD] Use programmatic rendering for omnibox chips (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/content_setting_image_view.h
diff --git a/chrome/browser/ui/views/location_bar/content_setting_image_view.h b/chrome/browser/ui/views/location_bar/content_setting_image_view.h
index f68232fc2c1baa58401f3d208a7db741f4b6e24e..3b00a0afb9f6f49716f4faae811c363800655638 100644
--- a/chrome/browser/ui/views/location_bar/content_setting_image_view.h
+++ b/chrome/browser/ui/views/location_bar/content_setting_image_view.h
@@ -37,6 +37,7 @@ class ContentSettingImageView : public IconLabelBubbleView,
public gfx::AnimationDelegate,
public views::WidgetObserver {
public:
+ // TODO(estade): remove |text_color| because it isn't necessary for MD.
ContentSettingImageView(ContentSettingsType content_type,
LocationBarView* parent,
const gfx::FontList& font_list,
@@ -56,9 +57,11 @@ class ContentSettingImageView : public IconLabelBubbleView,
// intervening "stay open" period.
static const int kAnimationDurationMS;
- // IconLabelBubbleView::
+ // IconLabelBubbleView:
bool ShouldShowBackground() const override;
double WidthMultiplier() const override;
+ SkColor GetTextColor() const override;
+ SkColor GetBorderColor() const override;
Peter Kasting 2015/11/05 06:22:11 Nit: List overrides in the same order they appear
Evan Stade 2015/11/05 23:59:06 Done.
// gfx::AnimationDelegate:
void AnimationEnded(const gfx::Animation* animation) override;

Powered by Google App Engine
This is Rietveld 408576698