Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 14232020: Ensure IDB transactions started before success arrives see correct medata (Closed)

Created:
7 years, 8 months ago by jsbell
Modified:
7 years, 8 months ago
Reviewers:
alecflett, dgrogan
CC:
blink-reviews, dgrogan, alecflett
Visibility:
Public.

Description

Ensure IDB transactions started before success arrives see correct medata Due to asynchronous IPC from the back-end and the difference between event enqueue and event dispatch, in multiprocess mode is was possible for a "versionchange" transaction's "complete" event to be dispatched before the open request's "success" event arrived. The new transaction would have stale metadata for indexes created during the "versionchange". This resulted in flaky tests under content_shell. Fix this by having object stores update the database's copy of the metadata during the "versionchange" transaction. This doesn't occur under DumpRenderTree; with content_shell it will flake occasionaly under load, e.g. running this single test in batches run-webkit-tests --iterations=30. BUG=225852 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
A LayoutTests/storage/indexeddb/metadata-race.html View 1 chunk +40 lines, -0 lines 0 comments Download
A LayoutTests/storage/indexeddb/metadata-race-expected.txt View 1 chunk +33 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
dgrogan@, alecflett@ - can you take a look? (I'm dismayed at the amount of plumbing ...
7 years, 8 months ago (2013-04-17 22:31:53 UTC) #1
dgrogan
lgtm Does this mean that all the metadata is updated "in place" on the front ...
7 years, 8 months ago (2013-04-18 00:00:10 UTC) #2
jsbell
On 2013/04/18 00:00:10, dgrogan wrote: > Does this mean that all the metadata is updated ...
7 years, 8 months ago (2013-04-18 00:04:43 UTC) #3
alecflett
lgtm Whats really a shame is that we can't figure out a nice way to ...
7 years, 8 months ago (2013-04-18 00:57:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/14232020/1
7 years, 8 months ago (2013-04-18 16:49:34 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 17:43:02 UTC) #6
Message was sent while issue was closed.
Change committed as 148671

Powered by Google App Engine
This is Rietveld 408576698