Correctly handle SPDY GOAWAY frames.

net/spdy/spdy_test_util_spdy2.cc

Index: net/spdy/spdy_test_util_spdy2.cc
diff --git a/net/spdy/spdy_test_util_spdy2.cc b/net/spdy/spdy_test_util_spdy2.cc
index dd340796e90116d2f8ab73edcb50f71a54bc27d9..3cee6513cf877ae16d98ed22863d234cc6ac6716 100644
--- a/net/spdy/spdy_test_util_spdy2.cc
+++ b/net/spdy/spdy_test_util_spdy2.cc
@@ -146,8 +146,14 @@ SpdyFrame* ConstructSpdyPing(uint32 ping_id) {
 // Construct a SPDY GOAWAY frame.
 // Returns the constructed frame.  The caller takes ownership of the frame.
 SpdyFrame* ConstructSpdyGoAway() {
+  return ConstructSpdyGoAway(0);
+}
+
+// Construct a SPDY GOAWAY frame.

[akalin, 2013/04/17 21:14:20]

i don't know if it's worth having the same comment in both the .h and the .cc
file. But I guess it's consistent.

[Ryan Hamilton, 2013/04/18 00:30:40]

Yeah, I was surprised to see them too, but decided to be consistent.  However,
I've removed *all* these redundant comments.  Cool?

[akalin, 2013/04/18 01:29:59]

even better!

+// Returns the constructed frame.  The caller takes ownership of the frame.
+SpdyFrame* ConstructSpdyGoAway(SpdyStreamId last_good_stream_id) {
   BufferedSpdyFramer framer(2, false);
-  return framer.CreateGoAway(0, GOAWAY_OK);
+  return framer.CreateGoAway(last_good_stream_id, GOAWAY_OK);
 }
 
 // Construct a SPDY WINDOW_UPDATE frame.