Correctly handle SPDY GOAWAY frames.

net/spdy/spdy_test_util_spdy2.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_test_util_spdy2.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
@@ skipping 128 matching lines @@
 // Construct a SPDY PING frame.
 // Returns the constructed frame.  The caller takes ownership of the frame.
 SpdyFrame* ConstructSpdyPing(uint32 ping_id) {
   BufferedSpdyFramer framer(2, false);
   return framer.CreatePingFrame(ping_id);
 }
 
 // Construct a SPDY GOAWAY frame.
 // Returns the constructed frame.  The caller takes ownership of the frame.
 SpdyFrame* ConstructSpdyGoAway() {
+  return ConstructSpdyGoAway(0);
+}
+
+// Construct a SPDY GOAWAY frame.

[akalin, 2013/04/17 21:14:20]

i don't know if it's worth having the same comment in both the .h and the .cc
file. But I guess it's consistent.

[Ryan Hamilton, 2013/04/18 00:30:40]

Yeah, I was surprised to see them too, but decided to be consistent.  However,
I've removed *all* these redundant comments.  Cool?

[akalin, 2013/04/18 01:29:59]

even better!

+// Returns the constructed frame.  The caller takes ownership of the frame.
+SpdyFrame* ConstructSpdyGoAway(SpdyStreamId last_good_stream_id) {
   BufferedSpdyFramer framer(2, false);
-  return framer.CreateGoAway(0, GOAWAY_OK);
+  return framer.CreateGoAway(last_good_stream_id, GOAWAY_OK);
 }
 
 // Construct a SPDY WINDOW_UPDATE frame.
 // Returns the constructed frame.  The caller takes ownership of the frame.
 SpdyFrame* ConstructSpdyWindowUpdate(
     const SpdyStreamId stream_id, uint32 delta_window_size) {
   BufferedSpdyFramer framer(2, false);
   return framer.CreateWindowUpdate(stream_id, delta_window_size);
 }
 
@@ skipping 665 matching lines @@
     RST_STREAM_INVALID,           // Status
     NULL,                         // Data
     0,                            // Length
     DATA_FLAG_NONE          // Data Flags
   };
   return kHeader;
 }
 
 }  // namespace test_spdy2
 }  // namespace net