Issue 1423123002: Merge to XFA: Add context to file load failures in pdfium_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1423123002: Merge to XFA: Add context to file load failures in pdfium_test. (Closed)

Created:
5 years, 1 month ago by dsinclair

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Add context to file load failures in pdfium_test. Currently if pdfium_test fails to load the document it just says it failed. This CL adds some extra context by looking at the error set by the load and reporting it to the user. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1413923006 . (cherry picked from commit e6eae266a48cdcfd464f52df68c97183a4f7987a) Committed: https://pdfium.googlesource.com/pdfium/+/eb815bf1c91d74bb03df52f8f7c586d2b2130341

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -1 line)			Patch
	M	samples/pdfium_test.cc	View		1 chunk	+29 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

dsinclair

Committed patchset #1 (id:1) manually as eb815bf1c91d74bb03df52f8f7c586d2b2130341 (presubmit successful).

5 years, 1 month ago (2015-10-27 17:08:47 UTC) #1

Message was sent while issue was closed.

TBRing, merge clean.