Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1413923006: Add context to file load failures in pdfium_test. (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add context to file load failures in pdfium_test. Currently if pdfium_test fails to load the document it just says it failed. This CL adds some extra context by looking at the error set by the load and reporting it to the user. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e6eae266a48cdcfd464f52df68c97183a4f7987a

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M samples/pdfium_test.cc View 1 1 chunk +29 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
dsinclair
PTAL.
5 years, 1 month ago (2015-10-27 14:19:20 UTC) #2
Tom Sepez
LGTM after fixing nit. https://codereview.chromium.org/1413923006/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/1413923006/diff/1/samples/pdfium_test.cc#newcode418 samples/pdfium_test.cc:418: fprintf(stderr, "Unknown error %ld\n", err); ...
5 years, 1 month ago (2015-10-27 16:25:36 UTC) #3
dsinclair
https://codereview.chromium.org/1413923006/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/1413923006/diff/1/samples/pdfium_test.cc#newcode418 samples/pdfium_test.cc:418: fprintf(stderr, "Unknown error %ld\n", err); On 2015/10/27 16:25:36, Tom ...
5 years, 1 month ago (2015-10-27 17:02:33 UTC) #4
dsinclair
5 years, 1 month ago (2015-10-27 17:03:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e6eae266a48cdcfd464f52df68c97183a4f7987a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698