Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1423063007: Simple Cache: Record sparse reads/writes in NetLog (Closed)

Created:
5 years, 1 month ago by Deprecated (see juliatuttle)
Modified:
4 years, 11 months ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@buf_not_buff
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simple Cache: Record sparse reads/writes in NetLog Simple Cache previously recorded regular reads and writes in the NetLog but not sparse reads and writes. This CL fixes that. BUG= Committed: https://crrev.com/141756c27f6422ccb966cb2b2d5889288524b9a6 Cr-Commit-Position: refs/heads/master@{#368449}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase, again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -8 lines) Patch
M net/disk_cache/simple/simple_entry_impl.cc View 1 2 3 6 chunks +32 lines, -0 lines 0 comments Download
M net/log/net_log_event_type_list.h View 1 2 3 5 chunks +58 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Deprecated (see juliatuttle)
PTAL, gavinp.
5 years, 1 month ago (2015-11-06 21:05:57 UTC) #2
Deprecated (see juliatuttle)
On 2015/11/06 21:05:57, ttuttle wrote: > PTAL, gavinp. Ping!
5 years ago (2015-12-04 18:56:09 UTC) #3
Deprecated (see juliatuttle)
On 2015/12/04 18:56:09, ttuttle wrote: > On 2015/11/06 21:05:57, ttuttle wrote: > > PTAL, gavinp. ...
4 years, 11 months ago (2016-01-04 15:54:05 UTC) #4
gavinp
lgtm lgtm.
4 years, 11 months ago (2016-01-08 15:32:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423063007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423063007/40001
4 years, 11 months ago (2016-01-08 19:17:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/114561) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-08 19:20:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423063007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423063007/60001
4 years, 11 months ago (2016-01-08 20:47:00 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-08 22:44:24 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 22:45:15 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/141756c27f6422ccb966cb2b2d5889288524b9a6
Cr-Commit-Position: refs/heads/master@{#368449}

Powered by Google App Engine
This is Rietveld 408576698