Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: net/log/net_log_event_type_list.h

Issue 1423063007: Simple Cache: Record sparse reads/writes in NetLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@buf_not_buff
Patch Set: rebase, again Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/simple/simple_entry_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/log/net_log_event_type_list.h
diff --git a/net/log/net_log_event_type_list.h b/net/log/net_log_event_type_list.h
index 612d08b5f9c23934b9bd35d6b3098fd88d987cfa..7b7350bbcd2059ae5003f5bcbed56def96d7486d 100644
--- a/net/log/net_log_event_type_list.h
+++ b/net/log/net_log_event_type_list.h
@@ -2426,14 +2426,12 @@ EVENT_TYPE(SIMPLE_CACHE_ENTRY_CREATE_BEGIN)
// }
EVENT_TYPE(SIMPLE_CACHE_ENTRY_CREATE_END)
-// This event is created when ReadEntry is called.
+// This event is created when ReadData is called.
// It contains the following parameters:
// {
// "index": <Index being read/written>,
// "offset": <Offset being read/written>,
// "buf_len": <Length of buffer being read to/written from>,
-// "truncate": <If present for a write, the truncate flag is set to true.
-// Not present in reads or writes where it is false>,
// }
EVENT_TYPE(SIMPLE_CACHE_ENTRY_READ_CALL)
@@ -2444,12 +2442,10 @@ EVENT_TYPE(SIMPLE_CACHE_ENTRY_READ_CALL)
// "index": <Index being read/written>,
// "offset": <Offset being read/written>,
// "buf_len": <Length of buffer being read to/written from>,
-// "truncate": <If present for a write, the truncate flag is set to true.
-// Not present in reads or writes where it is false>,
// }
EVENT_TYPE(SIMPLE_CACHE_ENTRY_READ_BEGIN)
-// This event is created when the Simple Cache finishes a ReadEntry call.
+// This event is created when the Simple Cache finishes a ReadData call.
// It contains the following parameters:
// {
// "bytes_copied": <Number of bytes copied. Not present on error>,
@@ -2470,7 +2466,7 @@ EVENT_TYPE(SIMPLE_CACHE_ENTRY_CHECKSUM_BEGIN)
// }
EVENT_TYPE(SIMPLE_CACHE_ENTRY_CHECKSUM_END)
-// This event is created when WriteEntry is called.
+// This event is created when WriteData is called.
// It contains the following parameters:
// {
// "index": <Index being read/written>,
@@ -2502,7 +2498,7 @@ EVENT_TYPE(SIMPLE_CACHE_ENTRY_WRITE_OPTIMISTIC)
// }
EVENT_TYPE(SIMPLE_CACHE_ENTRY_WRITE_BEGIN)
-// This event is created when the Simple Cache finishes a WriteEntry call.
+// This event is created when the Simple Cache finishes a WriteData call.
// It contains the following parameters:
// {
// "bytes_copied": <Number of bytes copied. Not present on error>,
@@ -2510,6 +2506,60 @@ EVENT_TYPE(SIMPLE_CACHE_ENTRY_WRITE_BEGIN)
// }
EVENT_TYPE(SIMPLE_CACHE_ENTRY_WRITE_END)
+// This event is created when ReadSparseData is called.
+// It contains the following parameters:
+// {
+// "offset": <Offset being read/written>,
+// "buf_len": <Length of buffer being read to/written from>,
+// "truncate": <If present for a write, the truncate flag is set to true.
+// Not present in reads or writes where it is false>,
+// }
+EVENT_TYPE(SIMPLE_CACHE_ENTRY_READ_SPARSE_CALL)
+
+// This event is created when the Simple Cache actually begins reading sparse
+// data from the cache entry.
+// It contains the following parameters:
+// {
+// "offset": <Offset being read/written>,
+// "buf_len": <Length of buffer being read to/written from>,
+// "truncate": <If present for a write, the truncate flag is set to true.
+// Not present in reads or writes where it is false>,
+// }
+EVENT_TYPE(SIMPLE_CACHE_ENTRY_READ_SPARSE_BEGIN)
+
+// This event is created when the Simple Cache finishes a ReadSparseData call.
+// It contains the following parameters:
+// {
+// "bytes_copied": <Number of bytes copied. Not present on error>,
+// "net_error": <Network error code. Only present on error>,
+// }
+EVENT_TYPE(SIMPLE_CACHE_ENTRY_READ_SPARSE_END)
+
+// This event is created when WriteSparseData is called.
+// It contains the following parameters:
+// {
+// "offset": <Offset being read/written>,
+// "buf_len": <Length of buffer being read to/written from>,
+// }
+EVENT_TYPE(SIMPLE_CACHE_ENTRY_WRITE_SPARSE_CALL)
+
+// This event is created when the Simple Cache actually begins writing sparse
+// data to the cache entry.
+// It contains the following parameters:
+// {
+// "offset": <Offset being read/written>,
+// "buf_len": <Length of buffer being read to/written from>,
+// }
+EVENT_TYPE(SIMPLE_CACHE_ENTRY_WRITE_SPARSE_BEGIN)
+
+// This event is created when the Simple Cache finishes a WriteSparseData call.
+// It contains the following parameters:
+// {
+// "bytes_copied": <Number of bytes copied. Not present on error>,
+// "net_error": <Network error code. Only present on error>,
+// }
+EVENT_TYPE(SIMPLE_CACHE_ENTRY_WRITE_SPARSE_END)
+
// This event is created when DoomEntry is called. It contains no parameters.
EVENT_TYPE(SIMPLE_CACHE_ENTRY_DOOM_CALL)
« no previous file with comments | « net/disk_cache/simple/simple_entry_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698