VM: Speculative inlining in precompiled code.

runtime/vm/flow_graph_optimizer.h

Index: runtime/vm/flow_graph_optimizer.h
diff --git a/runtime/vm/flow_graph_optimizer.h b/runtime/vm/flow_graph_optimizer.h
index ab9ba608448c48d0a67e989eb7626686f3b179bf..b238803423fc1b381f9a872f3a31bfad216e4666 100644
--- a/runtime/vm/flow_graph_optimizer.h
+++ b/runtime/vm/flow_graph_optimizer.h
@@ -16,9 +16,13 @@ class ParsedFunction;
 
 class FlowGraphOptimizer : public FlowGraphVisitor {
  public:
-  explicit FlowGraphOptimizer(FlowGraph* flow_graph)
+  explicit FlowGraphOptimizer(FlowGraph* flow_graph,

[srdjan, 2015/11/17 17:35:23]

Please add comment that use_speculative_inlining and black lists are only used
when always optimizing and speculative inlining is enabled ... or similar.
s/black_list/inlining_black_list/ add comment that it contains deopt-ids of
calls that may not be inlined.

+                              bool use_speculative_inlining = false,
+                              GrowableArray<intptr_t>* black_list = NULL)
       : FlowGraphVisitor(flow_graph->reverse_postorder()),
-        flow_graph_(flow_graph) { }
+        flow_graph_(flow_graph),
+        use_speculative_inlining_(use_speculative_inlining),
+        inlining_black_list_(black_list) { }

[srdjan, 2015/11/17 17:35:23]

ASSERT(!use_speculative_inlining || (black_list != NULL)); 

Serves as documentation as well./

[Florian Schneider, 2015/11/17 19:38:56]

Done.

   virtual ~FlowGraphOptimizer() {}
 
   FlowGraph* flow_graph() const { return flow_graph_; }
@@ -264,8 +268,14 @@ class FlowGraphOptimizer : public FlowGraphVisitor {
 
   const Function& function() const { return flow_graph_->function(); }
 
+  bool IsBlackListed(intptr_t deopt_id);
+
   FlowGraph* flow_graph_;
 
+  bool use_speculative_inlining_;

[srdjan, 2015/11/17 17:35:23]

const

[Florian Schneider, 2015/11/17 19:38:57]

Done.

+
+  GrowableArray<intptr_t>* inlining_black_list_;
+
   DISALLOW_COPY_AND_ASSIGN(FlowGraphOptimizer);
 };