VM: Speculative inlining in precompiled code.

runtime/vm/flow_graph_optimizer.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLOW_GRAPH_OPTIMIZER_H_
 #define VM_FLOW_GRAPH_OPTIMIZER_H_
 
 #include "vm/intermediate_language.h"
 #include "vm/flow_graph.h"
 
 namespace dart {
 
 class CSEInstructionMap;
 template <typename T> class GrowableArray;
 class ParsedFunction;
 
 class FlowGraphOptimizer : public FlowGraphVisitor {
  public:
-  explicit FlowGraphOptimizer(FlowGraph* flow_graph)
+  explicit FlowGraphOptimizer(FlowGraph* flow_graph,

[srdjan, 2015/11/17 17:35:23]

Please add comment that use_speculative_inlining and black lists are only used
when always optimizing and speculative inlining is enabled ... or similar.
s/black_list/inlining_black_list/ add comment that it contains deopt-ids of
calls that may not be inlined.

+                              bool use_speculative_inlining = false,
+                              GrowableArray<intptr_t>* black_list = NULL)
       : FlowGraphVisitor(flow_graph->reverse_postorder()),
-        flow_graph_(flow_graph) { }
+        flow_graph_(flow_graph),
+        use_speculative_inlining_(use_speculative_inlining),
+        inlining_black_list_(black_list) { }

[srdjan, 2015/11/17 17:35:23]

ASSERT(!use_speculative_inlining || (black_list != NULL)); 

Serves as documentation as well./

[Florian Schneider, 2015/11/17 19:38:56]

Done.

   virtual ~FlowGraphOptimizer() {}
 
   FlowGraph* flow_graph() const { return flow_graph_; }
 
   // Add ICData to InstanceCalls, so that optimizations can be run on them.
   // TODO(srdjan): StaticCals as well?
   void PopulateWithICData();
 
   // Use ICData to optimize, replace or eliminate instructions.
   void ApplyICData();
@@ skipping 225 matching lines @@
   void InstanceCallNoopt(InstanceCallInstr* instr);
 
   RawField* GetField(intptr_t class_id, const String& field_name);
 
   Thread* thread() const { return flow_graph_->thread(); }
   Isolate* isolate() const { return flow_graph_->isolate(); }
   Zone* zone() const { return flow_graph_->zone(); }
 
   const Function& function() const { return flow_graph_->function(); }
 
+  bool IsBlackListed(intptr_t deopt_id);
+
   FlowGraph* flow_graph_;
 
+  bool use_speculative_inlining_;

[srdjan, 2015/11/17 17:35:23]

const

[Florian Schneider, 2015/11/17 19:38:57]

Done.

+
+  GrowableArray<intptr_t>* inlining_black_list_;
+
   DISALLOW_COPY_AND_ASSIGN(FlowGraphOptimizer);
 };
 
 
 // Loop invariant code motion.
 class LICM : public ValueObject {
  public:
   explicit LICM(FlowGraph* flow_graph);
 
   void Optimize();
@@ skipping 155 matching lines @@
 // Optimize spill stores inside try-blocks by identifying values that always
 // contain a single known constant at catch block entry.
 class TryCatchAnalyzer : public AllStatic {
  public:
   static void Optimize(FlowGraph* flow_graph);
 };
 
 }  // namespace dart
 
 #endif  // VM_FLOW_GRAPH_OPTIMIZER_H_