Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: third_party/WebKit/public/web/WebView.h

Issue 1423053002: Make document.activeElement work with OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus-preserve-page-focus-on-subframe-navigations
Patch Set: Change plumbing a bit: use focusDocumentView on WebView and remove clearFocus from WebLocalFrame Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebView.h
diff --git a/third_party/WebKit/public/web/WebView.h b/third_party/WebKit/public/web/WebView.h
index ccd46ce923ab392a5ec3aa6c8e7f44ebcbcfe5de..03ac79b97d0b32a36e30fafca8cf83f29f3d7480 100644
--- a/third_party/WebKit/public/web/WebView.h
+++ b/third_party/WebKit/public/web/WebView.h
@@ -166,6 +166,12 @@ public:
virtual WebFrame* focusedFrame() = 0;
virtual void setFocusedFrame(WebFrame*) = 0;
+ // Sets the provided frame as focused and fires blur/focus events on any
+ // currently focused elements in old/new focused documents. Note that this
+ // is different from setFocusedFrame, which does not fire events on focused
+ // elements.
+ virtual void focusDocumentView(WebFrame*) = 0;
alexmos 2015/11/02 23:23:51 Instead of this, I could add a bool flag to setFoc
dcheng 2015/11/04 01:46:21 I think this is fine: it's pretty subtle though. M
+
// Focus the first (last if reverse is true) focusable node.
virtual void setInitialFocus(bool reverse) = 0;

Powered by Google App Engine
This is Rietveld 408576698