Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: third_party/WebKit/public/web/WebView.h

Issue 1423053002: Make document.activeElement work with OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus-preserve-page-focus-on-subframe-navigations
Patch Set: Change plumbing a bit: use focusDocumentView on WebView and remove clearFocus from WebLocalFrame Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 // children. 159 // children.
160 virtual WebFrame* findFrameByName( 160 virtual WebFrame* findFrameByName(
161 const WebString& name, WebFrame* relativeToFrame = 0) = 0; 161 const WebString& name, WebFrame* relativeToFrame = 0) = 0;
162 162
163 163
164 // Focus --------------------------------------------------------------- 164 // Focus ---------------------------------------------------------------
165 165
166 virtual WebFrame* focusedFrame() = 0; 166 virtual WebFrame* focusedFrame() = 0;
167 virtual void setFocusedFrame(WebFrame*) = 0; 167 virtual void setFocusedFrame(WebFrame*) = 0;
168 168
169 // Sets the provided frame as focused and fires blur/focus events on any
170 // currently focused elements in old/new focused documents. Note that this
171 // is different from setFocusedFrame, which does not fire events on focused
172 // elements.
173 virtual void focusDocumentView(WebFrame*) = 0;
alexmos 2015/11/02 23:23:51 Instead of this, I could add a bool flag to setFoc
dcheng 2015/11/04 01:46:21 I think this is fine: it's pretty subtle though. M
174
169 // Focus the first (last if reverse is true) focusable node. 175 // Focus the first (last if reverse is true) focusable node.
170 virtual void setInitialFocus(bool reverse) = 0; 176 virtual void setInitialFocus(bool reverse) = 0;
171 177
172 // Clears the focused element (and selection if a text field is focused) 178 // Clears the focused element (and selection if a text field is focused)
173 // to ensure that a text field on the page is not eating keystrokes we 179 // to ensure that a text field on the page is not eating keystrokes we
174 // send it. 180 // send it.
175 virtual void clearFocusedElement() = 0; 181 virtual void clearFocusedElement() = 0;
176 182
177 // Scrolls the node currently in focus into |rect|, where |rect| is in 183 // Scrolls the node currently in focus into |rect|, where |rect| is in
178 // viewport space. Returns true if an animation was started. 184 // viewport space. Returns true if an animation was started.
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 // context's ability to deal with that failure gracefully can be tested. 486 // context's ability to deal with that failure gracefully can be tested.
481 virtual void forceNextDrawingBufferCreationToFail() = 0; 487 virtual void forceNextDrawingBufferCreationToFail() = 0;
482 488
483 protected: 489 protected:
484 ~WebView() {} 490 ~WebView() {}
485 }; 491 };
486 492
487 } // namespace blink 493 } // namespace blink
488 494
489 #endif 495 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698